Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: data table comp/react tutorial links/typos #3366

Merged
merged 3 commits into from
Feb 8, 2023
Merged

docs: data table comp/react tutorial links/typos #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfaf3e5
docs: data table comp/react tutorial links/typos
jsehull Jan 25, 2023
6c68af5
Merge branch 'main' into docs/react-tutorial-typos
tay1orjones Feb 8, 2023
7da6029
Merge branch 'main' into docs/react-tutorial-typos
kodiakhq[bot] Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/pages/components/data-table/code.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ usage documentation, see the Storybooks for each framework below.
knobs={{ DataTable: ['isSortable'], Table: ['size', 'useZebraStyles'] }}
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--basic',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--minimal',
Expand Down Expand Up @@ -129,7 +129,7 @@ usage documentation, see the Storybooks for each framework below.
knobs={{ DataTable: ['isSortable'], Table: ['size', 'useZebraStyles'] }}
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable-selection--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable-selection--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--basic',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--default',
Expand Down Expand Up @@ -178,7 +178,7 @@ usage documentation, see the Storybooks for each framework below.
knobs={{ DataTable: ['isSortable'] }}
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--with-expansion',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--slotted-expanding-data',
Expand Down Expand Up @@ -227,7 +227,7 @@ usage documentation, see the Storybooks for each framework below.
id="with-batch-actions"
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable-batch-actions--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable-batch-actions--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--with-toolbar',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--default',
Expand Down
10 changes: 5 additions & 5 deletions src/pages/components/data-table/usage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ import { TrashCan, Save, Download } from '@carbon/icons-react';
knobs={{ DataTable: ['isSortable'], Table: ['size', 'useZebraStyles'] }}
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--basic',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--minimal',
Expand Down Expand Up @@ -127,7 +127,7 @@ import { TrashCan, Save, Download } from '@carbon/icons-react';
knobs={{ DataTable: ['isSortable'], Table: ['size', 'useZebraStyles'] }}
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable-selection--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable-selection--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--basic',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--default',
Expand Down Expand Up @@ -176,7 +176,7 @@ import { TrashCan, Save, Download } from '@carbon/icons-react';
knobs={{ DataTable: ['isSortable'] }}
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--with-expansion',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--slotted-expanding-data',
Expand Down Expand Up @@ -225,7 +225,7 @@ import { TrashCan, Save, Download } from '@carbon/icons-react';
id="with-batch-actions"
links={{
React:
'https://react.carbondesignsystem.com/?path=/story/components-datatable-batch-actions--usage',
'https://react.carbondesignsystem.com/?path=/story/components-datatable-batch-actions--default',
Angular:
'https://angular.carbondesignsystem.com/?path=/story/components-table--with-toolbar',
Vue: 'http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--default',
Expand Down Expand Up @@ -595,7 +595,7 @@ A sorted data table has three states: unsorted (`arrows`), sorted-up
sorted state and is only shown if sorting is activated. Only the column being
sorted should display an icon, and unsorted icons are only visible on hover. You
can see a demo of table sorting in
Carbon’s [React Storybook](https://react.carbondesignsystem.com/?path=/story/components-datatable-sorting--usage).
Carbon’s [React Storybook](https://react.carbondesignsystem.com/?path=/story/components-datatable-sorting--default).

<Row>
<Column colLg={12}>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/developing/react-tutorial/step-2.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ export default RepoTable;

This component uses two props, `rows` and `headers`, and returns a Carbon
`DataTable`. As for where the various `Table*` components came from? The
[DataTable story](https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--usage)
[DataTable story](https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--default)
in Storybook was used to put together the data table structure.

<InlineNotification>
Expand Down
3 changes: 1 addition & 2 deletions src/pages/developing/react-tutorial/step-3.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,7 @@ rows for the current "page". Update
<InlineNotification>

**Note:** We only pass the rows that we want our table to display. We can do
this by slicing the our array of rows depending on the first item and the page
size.
this by slicing the array of rows depending on the first item and the page size.

</InlineNotification>

Expand Down
1 change: 0 additions & 1 deletion src/pages/developing/react-tutorial/step-5.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ have not been updated to reflect changes for our next major version.

<AnchorLink>Fork, clone and branch</AnchorLink>
<AnchorLink>Create IBM Cloud account</AnchorLink>
<AnchorLink>Optimize Sass</AnchorLink>
<AnchorLink>Build for production</AnchorLink>
<AnchorLink>Create manifest file</AnchorLink>
<AnchorLink>Create static file</AnchorLink>
Expand Down