-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: react tutorial typo + link fixes #3359
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 1 out of 2 committers have signed the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for submitting the fix!
I have read the DCO document and I hereby sign the DCO. |
Thanks @aagonzales, I think I'm missing something for this DCO, should I try something else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like the author of the commit is not linked to your github profile (username is not clickable), so the CI is not picking it up you might have a mismatch in your local github config, here's some resources: https://www.git-tower.com/learn/git/faq/change-author-name-email |
I have read the DCO document and I hereby sign the DCO. |
Thanks for the help @francinelucca - we're going to close out this PR and resubmit a new PR to circumvent the validation issues |
Moved over to #3366, closing |
This commit fixes three "typos" in the React Tutorial section.
Changelog
New
n/a
Changed
Removed