Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: react tutorial typo + link fixes #3359

Closed

Conversation

jsehull
Copy link
Contributor

@jsehull jsehull commented Jan 20, 2023

This commit fixes three "typos" in the React Tutorial section.

  • 1 text related
  • 2 link related

Changelog

New

n/a

Changed

  • Step 2: update DataTable Story link w/newer url
    • code sample nearby has Table Expansion tags, so I'm guessing that was still the desired link to keep, otherwise it could be changed to the default for all tables?
  • Step 3: fix typo in pagination Note
    • "the our"

Removed

  • Step 5: rm unused Optimize Sass
    • unable to find appropriate reference, this may have been an old step

@vercel
Copy link

vercel bot commented Jan 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 5:07PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
@jsehull
@jesse Hull
Jesse Hull seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for submitting the fix!

@jsehull
Copy link
Contributor Author

jsehull commented Jan 20, 2023

I have read the DCO document and I hereby sign the DCO.

@jsehull
Copy link
Contributor Author

jsehull commented Jan 20, 2023

Thanks @aagonzales, I think I'm missing something for this DCO, should I try something else?

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francinelucca
Copy link
Collaborator

Thanks @aagonzales, I think I'm missing something for this DCO, should I try something else?

Looks like the author of the commit is not linked to your github profile (username is not clickable), so the CI is not picking it up
image

you might have a mismatch in your local github config, here's some resources: https://www.git-tower.com/learn/git/faq/change-author-name-email

@jsehull
Copy link
Contributor Author

jsehull commented Jan 25, 2023

I have read the DCO document and I hereby sign the DCO.

@jsehull
Copy link
Contributor Author

jsehull commented Jan 25, 2023

Thanks for the help @francinelucca - we're going to close out this PR and resubmit a new PR to circumvent the validation issues

@francinelucca
Copy link
Collaborator

Moved over to #3366, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants