Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix filter pattern icon images #3280

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified src/pages/patterns/filtering/images/filter-4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/patterns/filtering/images/filter-5.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/patterns/filtering/images/filter-6.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 10 additions & 8 deletions src/pages/patterns/filtering/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -145,22 +145,24 @@ be excluded from the results, then all filters should be selected at the start.
If the user typically wants to see only results related to one particular
criteria, then all filters should start as unselected.

If the filter(s) can be hidden in either a drawer, dropdown, or menu, then there
should be an indicator visible on the closed filter state that informs the user
that filters have been applied. At a minimum, the indicator should include the
number of filters applied and have the option to clear filters without
re-opening the filter container.

<Row>
<Column colLg={6}>
<Column colLg={8}>

![Example of hidden filters not applied](images/filter-5.png)

<Caption>Example of filter without selections</Caption>

</Column>
</Row>

<Column colLg={6}>
If the filter(s) can be hidden in either a drawer, dropdown, or menu, then there
should be an indicator visible on the closed filter state that informs the user
that filters have been applied. At a minimum, the indicator should include the
number of filters applied and have the option to clear filters without
re-opening the filter container.

<Row>
<Column colLg={8}>

![Example of hidden filters applied](images/filter-6.png)

Expand Down