Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): update to carbon v11.0.0 #2839

Merged
merged 203 commits into from
Mar 31, 2022

Conversation

tay1orjones
Copy link
Member

Updates the website to the v11 rc

jeanservaas and others added 30 commits May 7, 2021 15:44
Full copy edit and revision.
* docs(Modal): update modal live preview

* docs(Modal): add solo button example to code docs

* docs(Modal): update action handler

Co-authored-by: Josefina Mancilla <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: Andrea N. Cardona <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…stem#2338)

* comms: all about carbon additions

* update to the team page

* copyediting pass

* Update src/pages/all-about-carbon/who-uses-carbon.mdx

Co-authored-by: emyarod <[email protected]>

* Update src/pages/all-about-carbon/who-uses-carbon.mdx

Co-authored-by: emyarod <[email protected]>

* Update src/pages/all-about-carbon/who-uses-carbon.mdx

Co-authored-by: emyarod <[email protected]>

* Update src/pages/all-about-carbon/who-uses-carbon.mdx

Co-authored-by: emyarod <[email protected]>

* Update src/pages/all-about-carbon/who-uses-carbon.mdx

Co-authored-by: emyarod <[email protected]>

* Delete why-use-carbon copy.mdx

Co-authored-by: emyarod <[email protected]>
…ystem#2343)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Removed space between paragraphs in “Overview” and “Carbon is open source” so the copy reads continuously without paragraph breaks. Not needed and disrupting the one thought.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Added “be” to “they can be used” in the “Overview” paragraph

Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
typo to fix anchor link from "Actions: The main actions needed to complete or cancel the dialog task. Button groupings change based on modal variant. Use descriptive words for the actions like Add, Delete, Save and avoid vague words like Done or OK."

original line 60: "[Button groupings](/patterns/dialog-pattern#buttons-groups) change based on"
fixed line 60: "[Button groupings](/patterns/dialog-pattern#button-groups) change based on"
* testing

* fix(componeent-demo): audit-avt1-component-demo-label-text-area

* fix(componeent-demo): updated label title

* fix: undo change

* fix: remove console log

* Update src/components/ComponentDemo/ComponentDemo.js

Co-authored-by: TJ Egan <[email protected]>

* fix: add label variable

Co-authored-by: Josefina Mancilla <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…ystem#2371)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Previous link gives 404

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
chore: remove gatsby service worker and bump minimum node version to 14 (LTS)
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tay1orjones
Copy link
Member Author

tay1orjones commented Mar 31, 2022

@aagonzales I just updated this with all the latest from main. I believe the two largest pieces of work to verify we have correct here are the new accessibility pages and the progress bar work. Is there anything else?

@mbgower could you give the deploy preview a once-over to verify the accessibility changes you made came over properly to the v11 site here?

@thyhmdo could you validate the progress bar content came over correctly as well?

Thank you! 🙏

@tay1orjones
Copy link
Member Author

Dropdowns are intentionally missing from the website on various pages. They're not working at the moment, I'm still putting together a fix for it and need them commented out for now so the site deploy preview works so we can validate all the other changes.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I went through and compared the docs and I made some edits for the accessibility tabs directly too this branch. Hope that was ok. Everything else looks good including progress bar docs.

@mbgower
Copy link
Contributor

mbgower commented Mar 31, 2022

@tay1orjones a couple of things..

  1. The preamble is missing from accordion's accessibility.mdx. I didn't seem to have edit access, so you'll need to add the following before the anchor links:
<PageDescription>

Design annotations are needed for specific instances shown below, but for the standard accordion component, Carbon already incorporates accessibility.

</PageDescription>
  1. There's some weirdness in the formatting at the bottom of the checkbox accessibility.mdx page just before the "mixed" code formatting. It's actually on both versions. I can't see anything wrong in the code. Hopefully you can suss!

image

@tay1orjones tay1orjones marked this pull request as ready for review March 31, 2022 17:39
@joshblack joshblack changed the title chore(project): update to carbon v11.0.0-rc.0 chore(project): update to carbon v11.0.0 Mar 31, 2022
@tay1orjones tay1orjones merged commit 7e67227 into carbon-design-system:v11 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.