-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdowns): use correct v11 size
prop
#2820
fix(dropdowns): use correct v11 size
prop
#2820
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/7Tu7gbQPLg6Z5oJjf4bSEbzBdKRN |
size
prop
I pushed an update, I believe the component demo sizes are correct so I reverted them. Added a style fix for the border between dropdowns on the component demo and the width of the dropdowns should now be correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live demo
- The live demo dropdowns that sit on top of the live demo have increased in width and are too long. They should span the width of the demo window only. They should not span the right panel.
- The live demo dropdowns are also missing a vertical rule between them
Icons (library tab) and Pictograms (library tab)
- I think there were some overrides set on the dropdowns on both of these pages to match the styling of the Search input that it sits next to. Looks like we need to exclude the $border-strong bottom-border in these scenarios.
@jnm2377 @laurenmrice thanks for the great reviews! All should be fixed with one exception - the icons page will be fixed by #2832 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated - but as soon as I opened the deploy preview I was like WOAHHH the homepage looks so nice with the light banner updates!
Part of #2785
Changelog
Changed
To Review