Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdowns): use correct v11 size prop #2820

Merged
merged 6 commits into from
Mar 30, 2022

Conversation

tay1orjones
Copy link
Member

Part of #2785

Changelog

Changed

  • Update our usage of dropdowns to use the new size values from v11.

To Review

  • View component demos, the dropdowns should now be the proper size
  • View the icon library page, the dropdown in the search filter bar should now be properly sized.

@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/7Tu7gbQPLg6Z5oJjf4bSEbzBdKRN
✅ Preview: https://carbondesignsystem-git-fork-tay1orj-4ce866-carbon-design-system.vercel.app

@tay1orjones tay1orjones changed the title fix(dropdowns): use correct v11 size fix(dropdowns): use correct v11 size prop Mar 28, 2022
@tay1orjones
Copy link
Member Author

I pushed an update, I believe the component demo sizes are correct so I reverted them. Added a style fix for the border between dropdowns on the component demo and the width of the dropdowns should now be correct.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live demo

  • The live demo dropdowns that sit on top of the live demo have increased in width and are too long. They should span the width of the demo window only. They should not span the right panel.
  • The live demo dropdowns are also missing a vertical rule between them

To be:
Screen Shot 2022-03-28 at 5 34 40 PM

Current in this PR:
Screen Shot 2022-03-28 at 5 34 26 PM


Icons (library tab) and Pictograms (library tab)

  • I think there were some overrides set on the dropdowns on both of these pages to match the styling of the Search input that it sits next to. Looks like we need to exclude the $border-strong bottom-border in these scenarios.

To-be:
Screen Shot 2022-03-28 at 5 41 14 PM

Current in this PR:
Screen Shot 2022-03-28 at 5 41 04 PM

@jnm2377
Copy link
Contributor

jnm2377 commented Mar 30, 2022

The color palette dropdown is also shorter than the content switcher now

Screen Shot 2022-03-29 at 10 08 45 PM

@tay1orjones
Copy link
Member Author

@jnm2377 @laurenmrice thanks for the great reviews! All should be fixed with one exception - the icons page will be fixed by #2832

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated - but as soon as I opened the deploy preview I was like WOAHHH the homepage looks so nice with the light banner updates!

@kodiakhq kodiakhq bot merged commit f073623 into carbon-design-system:v11 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants