Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor updates to vue tutorial #2352

Merged
merged 2 commits into from
May 25, 2021
Merged

fix: minor updates to vue tutorial #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a0b07
fix: minor updates to vue tutorial
lee-chase May 25, 2021
77cd315
Merge branch 'main' into minorVueTutorialUpdates
kodiakhq[bot] May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/pages/developing/vue-tutorial/step-1.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ using the Vue CLI. These include:
- `@vue/cli-plugin-babel`: To ensure we produce well supported code.
- `@vue/cli-plugin-eslint`: To allow us to catch potential errors.
- `@vue/cli-plugin-unit-jest`: To allow us to unit test our code.
- `node-sass`: To allow us to use the sass css precompiler.
- `sass-loader`: To allow us to use the sass css precompiler.

NOTE: We could have installed these separately but using the CLI to set this up
for us ensures a good base config for these dependencies.
Expand Down Expand Up @@ -422,9 +422,7 @@ each individual icon we will use.
<!-- prettier-ignore-start -->
```javascript path=src/components/TutorialHeader/TutorialHeader.vue
<script>
import Notification20 from "@carbon/icons-vue/es/notification/20";
import UserAvatar20 from "@carbon/icons-vue/es/user--avatar/20";
import AppSwitcher20 from "@carbon/icons-vue/es/app-switcher/20";
import { Notification20, UserAvatar20, AppSwitcher20 } from '@carbon/icons-vue';

export default {
name: "TutorialHeader",
Expand Down
25 changes: 7 additions & 18 deletions src/pages/developing/vue-tutorial/step-2.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,21 +215,6 @@ You may notice that the styles look off. Don't worry, we'll fix these later.

In our second row we'll use `CvTabs` and `CvButton` components.

```javascript path=src/views/LandingPage/LandingPage.vue
const props = {
tabs: {
selected: 0,
triggerHref: '#',
role: 'navigation',
},
tab: {
href: '#',
role: 'presentation',
tabIndex: 0,
},
};
```

Modify the second row to use the `Tab` component.

```html path=src/views/LandingPage/LandingPage.vue
Expand Down Expand Up @@ -471,12 +456,16 @@ setting the background in an absolutely positioned pseudo element.
&::before {
content: '';
position: absolute;
left: -$spacing-05;
left: -$spacing-06;
top: 0;
right: -$spacing-05;
right: -$spacing-06;
bottom: 0;
background: $ui-01;
z-index: -1;
}

> * {
/* lift above position absolute */
position: relative;
}
}
```
Expand Down
4 changes: 1 addition & 3 deletions src/pages/developing/vue-tutorial/step-4.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,7 @@ While we're here next to the component imports, let's import the icons that
we'll need as well.

```javascript path=src/views/LandingPage/LandingPage.vue
import Globe32 from '@carbon/icons-vue/lib/globe/32';
import PersonFavorite32 from '@carbon/icons-vue/lib/person--favorite/32';
import Application32 from '@carbon/icons-vue/lib/application/32';
import { Globe32, PersonFavorite32, Application32 } from '@carbon/icons-vue';
```

<InlineNotification>
Expand Down