Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1946 component live demo bug #2287

Merged

Conversation

andreancardona
Copy link
Contributor

Closes #1946

Updates the Component Live Demo for ContentSwitcher to include the size variant props as seen below:

Screen Shot 2021-05-06 at 11 42 14 AM

Testing

  • Make sure size variants for ContentSwitcher change appropriately to sm, md, lg
  • Make sure size variants for ContentSwitcher change in both the usage and code tabs

@andreancardona andreancardona requested a review from a team May 6, 2021 17:44
@andreancardona andreancardona requested a review from a team as a code owner May 6, 2021 17:44
@vercel
Copy link

vercel bot commented May 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/4Uq8mRDgqyFfMQo8RVPvPdF5ty8D
✅ Preview: https://carbondesignsy-git-fork-andreancardona-1946-component-li-ffa037.vercel.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit 2684698 into carbon-design-system:main May 10, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* update(content-switcher): update live demo props

* update(content-switcher): update live demo props

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* update(content-switcher): update live demo props

* update(content-switcher): update live demo props

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[content switcher] component live demo bug
4 participants