fix(ComponentDemo): properly theme floating components #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/Be7XzhUh5tSZPWq63C9RNfMNTsCs |
emyarod
force-pushed
the
2233-component-live-demo-theming-issue
branch
from
e72a2ab
to
5615eb9
Compare
aagonzales
reviewed
Apr 30, 2021
|
I will address it separately since I believe the underlying cause is different compared to common issue found in the specific components in this PR |
aagonzales
approved these changes
Apr 30, 2021
This was referenced May 3, 2021
tay1orjones
approved these changes
May 4, 2021
tw15egan
approved these changes
May 5, 2021
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…-system#2262) * fix(ComponentDemo): update table zebra stripe styles * fix(ComponentDemo): update sortable table hover styles * fix(ComponentDemo): update themed tooltip styles * fix(ComponentDemo): update themed date picker styles * fix(ComponentDemo): update themed overflow menu styles Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…-system#2262) * fix(ComponentDemo): update table zebra stripe styles * fix(ComponentDemo): update sortable table hover styles * fix(ComponentDemo): update themed tooltip styles * fix(ComponentDemo): update themed date picker styles * fix(ComponentDemo): update themed overflow menu styles Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2233
This PR adds a data attribute to the document body when the component demo theme is changed so that floating components can reference CSS theme variables