Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(community-index): 1800-avt1-community-index-downshift-label #2116

Merged
merged 6 commits into from
Feb 4, 2021
Merged

fix(community-index): 1800-avt1-community-index-downshift-label #2116

merged 6 commits into from
Feb 4, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Feb 2, 2021 •
edited
Loading

Closes #1800

  • Fixes Downshift accessibility violation by adding a textTitle prop to the Dropdown component in Component Index.

TESTING:

@andreancardona andreancardona requested a review from a team as a code owner February 2, 2021 17:45
@vercel
Copy link

vercel bot commented Feb 2, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/plc6ns060
✅ Preview: https://carbondesignsy-git-fork-andreancardona-1800-avt1-communi-340aec.carbon-design-system.vercel.app

@andreancardona andreancardona mentioned this pull request Feb 2, 2021
Closed
60 tasks
aagonzales
aagonzales reviewed Feb 2, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! But can we had a hover background to the closed state? Color: $hover-ui

image

tay1orjones
tay1orjones approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may fall out of the bounds of the implementation here and be more of a question for the component implementation itself, but should clicking the label also close the dropdown once it's open?

It currently has a bit of an odd focus movement - the dropdown opens, and then when the label is clicked the focus flashes, moving from the input to the listbox

focus.movement.mov

@andreancardona
Copy link
Contributor Author

It looks good! But can we had a hover background to the closed state? Color: $hover-ui

image

updated the hover! @aagonzales

aagonzales
aagonzales approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andreancardona andreancardona merged commit 7fe531d into carbon-design-system:master Feb 4, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @tay1orjones @natashadecoste
fix(community-index): 1800-avt1-community-index-downshift-label (carb…
6a5de33 
…on-design-system#2116)

* fix(community-index): 1800-avt1-community-index-downshift-label

* update(component-index): added on hover

Co-authored-by: Taylor Jones <[email protected]>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @tay1orjones @natashadecoste
fix(community-index): 1800-avt1-community-index-downshift-label (carb…
caf1edc 
…on-design-system#2116)

* fix(community-index): 1800-avt1-community-index-downshift-label

* update(component-index): added on hover

Co-authored-by: Taylor Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@aagonzales aagonzales aagonzales approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉 type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit-avt1-community-insight-component-index: id downshift label
4 participants
@andreancardona @tay1orjones @aagonzales @dakahn