Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(partners): 2028-aat-all-about-carbon-partners-h3-element #2105

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix(partners): 2028-aat-all-about-carbon-partners-h3-element #2105

merged 1 commit into from
Jan 27, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Jan 26, 2021 •
edited
Loading

Closes #2028

  • Multiple The people titles / id's was causing an accessibility issue.

Removed

  • Extracted markdown title The people into an h3 element to provide a different id

Testing

@andreancardona andreancardona self-assigned this Jan 26, 2021
@andreancardona andreancardona requested a review from a team January 26, 2021 19:40
@andreancardona andreancardona requested a review from a team as a code owner January 26, 2021 19:40
@vercel
Copy link

vercel bot commented Jan 26, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/hz4r9j5by
✅ Preview: https://carbondesignsy-git-fork-andreancardona-1951-aat-all-abou-6968eb.carbon-design-system.vercel.app

@andreancardona andreancardona mentioned this pull request Jan 26, 2021
Closed
60 tasks
@andreancardona andreancardona changed the title fix(partners): 1951-aat-all-about-carbon-partners-h3-element fix(partners): 2028-aat-all-about-carbon-partners-h3-element Jan 26, 2021
tw15egan
tw15egan approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing the a11y violation 👍 ✅

janchild
janchild approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@alisonjoseph
Copy link
Member

LGTM! I wonder if this isn't an issue we should open on the theme and find a way to fix it automatically if someone adds the same headers to the page?

@kodiakhq kodiakhq bot merged commit 26cec8d into carbon-design-system:master Jan 27, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @natashadecoste
fix(partners): 1951-aat-all-about-carbon-partners-h3-element (carbon-…
8a5620e 
…design-system#2105)
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @natashadecoste
fix(partners): 1951-aat-all-about-carbon-partners-h3-element (carbon-…
52d6562 
…design-system#2105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@janchild janchild janchild approved these changes

@dakahn dakahn Awaiting requested review from dakahn

Assignees

@andreancardona andreancardona

Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit-avt1-all-about-carbon-partners: h3 element id carbon-website
4 participants
@andreancardona @alisonjoseph @tw15egan @janchild