Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(usage): inline-loading #1562

Merged
merged 8 commits into from
Aug 17, 2020
Merged

docs(usage): inline-loading #1562

merged 8 commits into from
Aug 17, 2020

Conversation

aagonzales
Copy link
Member

@aagonzales aagonzales commented Aug 12, 2020

@aagonzales aagonzales requested a review from a team August 12, 2020 19:25
@aagonzales aagonzales requested a review from a team as a code owner August 12, 2020 19:25
@vercel
Copy link

vercel bot commented Aug 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/7iupjytkr
✅ Preview: https://carbon-website-git-fork-aagonzales-inline-loading-docs.carbon-design-system.vercel.app

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/jp8kk5hj2
✅ Preview: https://carbondesignsystem-git-fork-aagonzales-inline-loading-docs.carbon-design-system.vercel.app

@vercel vercel bot temporarily deployed to Preview August 12, 2020 19:25 Inactive
@aagonzales aagonzales requested review from janchild and jeanservaas and removed request for jillianhowarth August 12, 2020 19:25
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. omg that little guys is so tiny.

One super small thing:

just center this guy, the margin on the left is slightly larger than the one on the right.

image

@aagonzales
Copy link
Member Author

@jeanservaas good catch! One day I'll have a perfect PR.

Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aagonzales this is great! There were just a few little content tweaks.

src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/inline-loading/usage.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – carbon-website August 14, 2020 20:36 Inactive
@vercel vercel bot temporarily deployed to Preview – carbondesignsystem August 14, 2020 20:36 Inactive
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! 🥂

@vercel vercel bot had a problem deploying to Preview – carbondesignsystem August 14, 2020 20:39 Error
@vercel vercel bot had a problem deploying to Preview – carbon-website August 14, 2020 20:39 Error
@vercel vercel bot temporarily deployed to Preview – carbondesignsystem August 17, 2020 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview – carbon-website August 17, 2020 18:43 Inactive
@kodiakhq kodiakhq bot merged commit a61d42c into carbon-design-system:master Aug 17, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* docs(usage): inline-loading

* Update inline-loading-modifier.png

* Apply suggestions from code review

Co-authored-by: Jan Child <[email protected]>

Co-authored-by: Jan Child <[email protected]>
Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* docs(usage): inline-loading

* Update inline-loading-modifier.png

* Apply suggestions from code review

Co-authored-by: Jan Child <[email protected]>

Co-authored-by: Jan Child <[email protected]>
Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants