Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(file-uploader): usage content updates #1527

Merged
merged 22 commits into from
Aug 12, 2020
Merged

docs(file-uploader): usage content updates #1527

merged 22 commits into from
Aug 12, 2020

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Aug 6, 2020 •
edited
Loading

Closes #1403

Add new images and update content with the new content template

New

  • images
  • content

@laurenmrice laurenmrice requested a review from a team August 6, 2020 20:34
@laurenmrice laurenmrice requested a review from a team as a code owner August 6, 2020 20:34
@vercel
Copy link

vercel bot commented Aug 6, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/ezd1zbfqo
✅ Preview: https://carbon-website-git-fork-laurenmrice-file-uploader-usage-docs.carbon-design-system.vercel.app

This was referenced Aug 6, 2020
Closed
Closed
jillianhowarth
jillianhowarth suggested changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@jillianhowarth jillianhowarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome @laurenmrice! Just a few minor changes 🙂

src/pages/components/file-uploader/usage.mdx Show resolved Hide resolved
src/pages/components/file-uploader/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/file-uploader/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/file-uploader/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/file-uploader/usage.mdx Outdated Show resolved Hide resolved
jeanservaas
jeanservaas reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg super cute. Just a couple of comments!

For these guys, I think we're going italic on the "large, medium and small"

image

For this guy, the primary button in that panel should be on the right, the secondary button would be a Gray 60 and the stroke between would be a gray 100.

image

I might try dashing the magenta outline here so it's just like the drag and drop outline

image

Little green check mark icon will have a Black check mark inside of it (not white) for contrast accessibility. One other question, this looks great, but are those buttons on grid (two columns?)

image

Otherwise awesome!

@vercel vercel bot temporarily deployed to Preview August 11, 2020 16:04 Inactive
dakahn
dakahn suggested changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to the reader controls

🏄 ♿

src/pages/components/file-uploader/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/file-uploader/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/file-uploader/usage.mdx Outdated Show resolved Hide resolved
jeanservaas
jeanservaas approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the quick tab update, perfect!

jillianhowarth
jillianhowarth approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@jillianhowarth jillianhowarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @laurenmrice!

@kodiakhq kodiakhq bot merged commit 02cd08d into carbon-design-system:master Aug 12, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@laurenmrice @tw15egan @natashadecoste
docs(file-uploader): usage content updates (carbon-design-system#1527)
48740ee 
* update: content

* update: images

* content edit

* update: edit content

* image column edit

* Update: content edit

* update: content

* update: images

* content edit

* update: edit content

* image column edit

* Update: content edit

* image review edits

* content edit review

* image update

Co-authored-by: TJ Egan <[email protected]>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@laurenmrice @tw15egan @natashadecoste
docs(file-uploader): usage content updates (carbon-design-system#1527)
d9635d3 
* update: content

* update: images

* content edit

* update: edit content

* image column edit

* Update: content edit

* update: content

* update: images

* content edit

* update: edit content

* image column edit

* Update: content edit

* image review edits

* content edit review

* image update

Co-authored-by: TJ Egan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillianhowarth jillianhowarth jillianhowarth approved these changes

@dakahn dakahn dakahn approved these changes

@jeanservaas jeanservaas jeanservaas approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Update file uploader to follow new component template
5 participants
@laurenmrice @jillianhowarth @dakahn @jeanservaas @tw15egan