Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart type cards #1270

Merged

Conversation

designertyler
Copy link
Contributor

Closes #1263

This adds the grouped bar (horizontal), stacked bar (horizontal), and pie chart tiles to the chart types page.

image

image

@designertyler designertyler requested review from jeanservaas and a team June 9, 2020 18:29
@designertyler designertyler requested a review from a team as a code owner June 9, 2020 18:29
@vercel
Copy link

vercel bot commented Jun 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/6gvn9lopa
✅ Preview: https://carbon-website-git-fork-designertyler-chart-type-cards.carbon-design-system.vercel.app

@theiliad
Copy link
Member

theiliad commented Jun 9, 2020

thank you @designertyler this is great!

#987 needs to be merged before this PR since links added in this PR need to point to the new demo link

Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @designertyler, totally fine with your artwork, but a couple of comments:

  • can you do me a quick favor and clean up some of my old inconsistency — can we establish a consistent bottom margin for all of these tiles. I just noticed that some of them have a much smaller margin than others. Maybe we can pick a number like 72px, or 64px whatever works and make it consistent

  • radar chart actually has a design now (it may also have code, we can ask elide) so we should enable it now (not have the disabled design)

  • Remove "design only" tag off of stacked area

  • Enable and add design only tag to tree map, heat map, parallel coordinates and stream chart

image

image

@theiliad
Copy link
Member

theiliad commented Jun 10, 2020 via email

Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@designertyler Could you please change the page description to the following:

Start by identifying the purpose of the visualization and then choose the appropriate chart type.

Thank you.

@vercel vercel bot temporarily deployed to Preview June 22, 2020 15:00 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2020 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2020 16:10 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2020 16:28 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2020 16:28 Inactive
@vercel vercel bot temporarily deployed to Preview July 7, 2020 16:44 Inactive
@jeanservaas
Copy link
Contributor

jeanservaas commented Jul 7, 2020

Looks good, just take design tag off of these two, they're live now. And make the Gauge/meter just say Gauge.

We need to add a meter tile but we can do it in a separate PR. The code is not live yet.

image

@vercel vercel bot temporarily deployed to Preview July 8, 2020 14:36 Inactive
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good time for us to start creating a meter icon as well

@mjabbink
Copy link
Contributor

@designertyler We need to get this wrapped.

For my understanding
— Make image tile for Meter (with design only tag)
— Remove tag from Gauge and stacked area chart
— Remove Stacked area chart content from Design only section (Only Meter to remain)

—Create a image card for Meter in another issue. Meter soon to be released.

Did I miss anything? Maybe Histogram? I believe that is in our near future.

@designertyler
Copy link
Contributor Author

@mjabbink This PR was to just add the grouped bar (horizontal), stacked bar (horizontal), and pie chart tiles on the chart overview page. I think the other additions were being worked on when this was opened.

We do have an issue to make an image tile for meter here #1355 that would separate the meter/gauge tiles and remove the tags.

I'll get a PR opened to remove the duplicate content under "Design only" and the stacked area shouldn't have a tag on the Chart types page.

@mjabbink
Copy link
Contributor

👍

@designertyler designertyler deleted the chart-type-cards branch August 3, 2020 20:25
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* adds thumbnails

* image update

* image udate

* Description update

* enable cards

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* link fix

* grouped bar link fix

* removed design only tags

Co-authored-by: Eliad Moosavi <[email protected]>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* adds thumbnails

* image update

* image udate

* Description update

* enable cards

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* Update src/pages/data-visualization/chart-types/index.mdx

Co-authored-by: Eliad Moosavi <[email protected]>

* link fix

* grouped bar link fix

* removed design only tags

Co-authored-by: Eliad Moosavi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart types page needs additional icons designed
7 participants