Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(code): add code tab content to modal #1126

Closed
wants to merge 28 commits into from
Closed

feat(code): add code tab content to modal #1126

wants to merge 28 commits into from

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Apr 24, 2020 •
edited
Loading

Changelog

New

  • Updated code doc for modal with technical usage instructions. The team should discuss the unified content style in this area, but for this PR, would like to focus on:
    • Improving the answers on "how to use feature X technically" questions
    • Getting the look and feel right

@netlify
Copy link

netlify bot commented Apr 24, 2020 •
edited
Loading

Deploy preview for carbon-website ready!

Built with commit 5585316

https://deploy-preview-1126--carbon-website.netlify.app

@vercel
Copy link

vercel bot commented Apr 24, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/db3y39pnl
✅ Preview: https://carbon-website-git-fork-asudoh-modal-code.carbon-design-system.vercel.app

@asudoh asudoh changed the title feat(code): add usage content to modal feat(code): add code tab content to modal Apr 24, 2020
@vercel vercel bot temporarily deployed to Preview April 24, 2020 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview April 24, 2020 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview April 24, 2020 14:54 Inactive
@asudoh asudoh requested a review from aagonzales April 28, 2020 09:00
@asudoh asudoh marked this pull request as ready for review April 28, 2020 09:01
@asudoh asudoh requested review from a team April 28, 2020 09:01
@asudoh asudoh requested a review from a team as a code owner April 28, 2020 09:01
@asudoh asudoh requested review from connor-leech, sstrubberg and andreancardona and removed request for a team April 28, 2020 09:01
@ghost ghost requested review from aledavila and tw15egan April 28, 2020 09:01
@vercel vercel bot temporarily deployed to Preview June 4, 2020 16:49 Inactive
@emyarod emyarod requested a review from janchild June 4, 2020 16:51
janchild
janchild approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@alisonjoseph alisonjoseph mentioned this pull request Jun 5, 2020
Closed
41 tasks
aagonzales
aagonzales approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo-hoo! I think it looks good now.

@vercel vercel bot temporarily deployed to Preview June 11, 2020 22:43 Inactive
@alisonjoseph
Copy link
Member

closing as we are moving these docs to storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@aledavila aledavila aledavila approved these changes

@janchild janchild janchild approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@asudoh @aagonzales @alisonjoseph @aledavila @janchild @joshblack @andreancardona @emyarod