Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(video-player): migrate caem-video-player features #12113

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

m4olivei
Copy link
Contributor

Related Ticket(s)

ADCMS-6664

Description

Migrates features from caem-video-player and caem-video-player-container mainly intersection-mode, which works for scrolling video into view, as well as multiple card in card with video in a carousel.

Testing instructions

  • Browse to Video player > Autoplay to test standalone video player intersection mode
  • Browse to Card in Card > With carousel video to test the intersection mode within a <c4d-carousel> component

Changelog

New

  • intersection-mode attribute for <c4d-video-player> which will auto play/pause as the video scrolls into / out of the viewport

@m4olivei m4olivei requested a review from a team as a code owner November 19, 2024 19:15
@m4olivei m4olivei requested review from bruno-amorim, marcelojcs, andy-blum and Valentin-Sorin-Nicolae and removed request for a team November 19, 2024 19:15
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 9e8b9c7
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/673de073e470220008dddb26
😎 Deploy Preview https://deploy-preview-12113--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 9e8b9c7
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/673de07300e9e8000921170a
😎 Deploy Preview https://deploy-preview-12113--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant