Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content-group): adding h-tags to headings #11739

Closed
wants to merge 7 commits into from
Closed

fix(content-group): adding h-tags to headings #11739

wants to merge 7 commits into from

Conversation

marcelojcs
Copy link
Contributor

Related Ticket(s)

V2 version of this PR
#11738

Description

Adding the respective H tags to content-group-heading and content-item-heading components.

@marcelojcs marcelojcs requested a review from a team as a code owner April 23, 2024 18:24
@marcelojcs marcelojcs requested review from emyarod and ariellalgilmore and removed request for a team April 23, 2024 18:24
@marcelojcs marcelojcs mentioned this pull request Apr 23, 2024
Merged
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 23, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11739/index.html

Built with commit: 1cd92cb830afb18bb92bba769cbca0fc4687a9fe

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 23, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11739/index.html

Built with commit: 1cd92cb830afb18bb92bba769cbca0fc4687a9fe

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 23, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11739/index.html

Built with commit: 1cd92cb830afb18bb92bba769cbca0fc4687a9fe

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 8, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11739/index.html

Built with commit: 1cd92cb830afb18bb92bba769cbca0fc4687a9fe

@andy-blum andy-blum requested review from m4olivei and andy-blum July 12, 2024 13:59
m4olivei
m4olivei suggested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are spacing regressions here comparing this to current v2 for Content Group:

image

m4olivei
m4olivei reviewed Dec 11, 2024
View reviewed changes
packages/web-components/src/components/content-group/content-group-heading.ts
super.connectedCallback();
}

render() {
return html` <slot></slot> `;
return html` <h3><slot></slot></h3> `;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was handled differently in #12074.

@m4olivei
Copy link
Contributor

I think we're OK to close this one. Was handled in #12074.

@m4olivei m4olivei closed this Dec 11, 2024
@marcelojcs marcelojcs deleted the fix/group-item-headin-fixes-v2 branch January 6, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei requested changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcelojcs @ibmdotcom-bot @m4olivei @andy-blum @kennylam