Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Figma] discrepancy with UI shell header and right panel color tokens #742

Closed
Tracked by #16296
laurenmrice opened this issue Dec 13, 2023 · 2 comments
Closed
Tracked by #16296
Assignees

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Dec 13, 2023

Acceptance criteria

  • There seems to be some discrepancies across the code, design kit, and website docs for the color tokens used in the UI Shell Header and the Right panel.
  • Double check to see what the correct color tokens to be and if they are being applied correctly across these three different areas.
@laurenmrice laurenmrice added the version: 11 Issues pertaining to Carbon v11 label Jan 29, 2024
@laurenmrice laurenmrice added severity: 3 https://ibm.biz/carbon-severity and removed severity: 4 https://ibm.biz/carbon-severity labels Feb 8, 2024
@laurenmrice laurenmrice added this to the 2024 Q1 milestone Feb 8, 2024
@laurenmrice laurenmrice modified the milestones: 2024 Q1, 2024 Q2 Mar 27, 2024
@laurenmrice laurenmrice removed the version: 11 Issues pertaining to Carbon v11 label Apr 1, 2024
@alina-jacob
Copy link
Member

alina-jacob commented Jul 2, 2024

Inference

Figma reference file


UI shell header

  • Style tab
  • Color: Add spec for divider - Divider | border | $border-subtle
  • Sub-menu: Update sub-menu's Selected state to Open / Expanded.
  • Sub-menu: Update sub-menu item's image to include item's Selected state as well.
  • Typography: Add typography spec for sub-menu item - Sub-menu item | 14 / 0.875 | Regular / 400 | $body-compact-01

--

  • Figma
  • Sub-menu: Sub-menu item's Selected state is missing in Figma.
  • Header actions: [Enhancement] - The header action buttons can have an open state which opens up a side nav / panel / popover.

UI shell right panel

  • Style tab
  • Color: Update Panel's border spec as - border-left, border-right, border-bottom
  • Color: Should we be adding shadow, overlay specs in our docs? (Yes, audit for other components as well)
  • Item: Add border spec for Selected state - border-left | $focus-interactive

UI shell left panel

  • Style tab
  • Color: [Enhancement] Potential to add border-right and border-left to the UI shell left panel. (Yes, can be included as a prop)
    These are the UI shell theme options explored by Anna.
  • Color: Add specs for Overlay - Overlay | background-color | $overlay
  • Icon: Delete this section as this is repeat information.

@alina-jacob
Copy link
Member

Updated the story points from 3 to 5 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants