-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-shell): make company
in Header
slottable
#1764
feat(ui-shell): make company
in Header
slottable
#1764
Conversation
That just looks like an encoding issue, did you set a/the correct |
Yes, charset (utf-8) is in the meta tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about making the company
prop slottable so the end user can override this behavior?
{#if company || $$slots.company}
<span class:bx--header__name--prefix="{true}"><slot name="company">{company} </slot></span>
{/if}
Hey, I think its a good idea. Thanks. |
company
in Header
slottable
Ahhh, the doc fixes should of course have been made directly in |
@brunnerh Nice catch – I can add that back in. |
Released in v0.77.0 |
I've noticed that the ui shell has a little glitch during load in our app.
The
Â
disappearing after load but it causes a glitch.The root cause is an
character in the company text span.Maybe somebody else faced with this glitch too, so I created a small improvement for that.