Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruler interaction replacing Grid mouse listeners for comparative tooltips #499

Merged
merged 46 commits into from
Apr 27, 2020
Merged

Ruler interaction replacing Grid mouse listeners for comparative tooltips #499

merged 46 commits into from
Apr 27, 2020

Commits on Apr 1, 2020

  1. add ruler and axis tooltip

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    42c8eaf View commit details
    Browse the repository at this point in the history

  2. move ruler logic to it's own graphFrameComponent

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    2b778ba View commit details
    Browse the repository at this point in the history

  3. refactor, add axis tooltip dynamic width, add matching elements hovering

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    cf6eeb2 View commit details
    Browse the repository at this point in the history

  4. use getDomainValue instead of hardcoded accessor

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    6c1bfa5 View commit details
    Browse the repository at this point in the history

  5. add snap to nearest point

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    269ab2a View commit details
    Browse the repository at this point in the history

  6. use getSVGElementSize to get backdrop height

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    7480ff6 View commit details
    Browse the repository at this point in the history

  7. remove useless code

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    3c56aa0 View commit details
    Browse the repository at this point in the history

  8. add trigger mouseout in hideRuler to only highlight single hovered el… 

    …ement
    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    be5e962 View commit details
    Browse the repository at this point in the history

  9. WIP

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    0aefa01 View commit details
    Browse the repository at this point in the history

  10. fix categorical scale elements mouseover trigger

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    2026a0d View commit details
    Browse the repository at this point in the history

  11. fix close points mouseover/out trigger

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    8283efc View commit details
    Browse the repository at this point in the history

  12. fix import order and package version

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    bc65c85 View commit details
    Browse the repository at this point in the history

  13. add more test data

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    f1fb498 View commit details
    Browse the repository at this point in the history

  14. add crosshair cursor when ruler is active to better select data points

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    5aec426 View commit details
    Browse the repository at this point in the history

  15. refactor, more docs

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    3718884 View commit details
    Browse the repository at this point in the history

  16. fix axis tooltip baseline

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    3dcd533 View commit details
    Browse the repository at this point in the history

  17. minor refactor 

    Co-Authored-By: Zvonimir Fras <[email protected]>
    @lucafalasco @zvonimirfras
    lucafalasco and zvonimirfras committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    178ea29 View commit details
    Browse the repository at this point in the history

  18. change ruler color

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    192e273 View commit details
    Browse the repository at this point in the history

  19. a11y bubble

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    ab66a64 View commit details
    Browse the repository at this point in the history

  20. only show ruler for continuous domain - wip

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    b96da08 View commit details
    Browse the repository at this point in the history

  21. add support for top axis

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    7121b63 View commit details
    Browse the repository at this point in the history

  22. no need to support discrete scales anymore

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    11589b6 View commit details
    Browse the repository at this point in the history

  23. make sure tooltip does not go out of axis bbox

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    00d44af View commit details
    Browse the repository at this point in the history

  24. remove axis tooltip

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    ae93c80 View commit details
    Browse the repository at this point in the history

  25. only show ruler if there's match with data points

    @lucafalasco
    lucafalasco committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    7e46f2b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. only show ruler on timescale linechart

    @lucafalasco
    lucafalasco committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    6f3ffb9 View commit details
    Browse the repository at this point in the history

  2. add filter for items getting null values at times, breaking tooltip

    @lucafalasco
    lucafalasco committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    fe6457a View commit details
    Browse the repository at this point in the history

  3. refactor

    @lucafalasco
    lucafalasco committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    c1edff4 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. fix(core): update import path carbon-components 

    fix carbon-design-system#546
    @natashadecoste @lucafalasco
    natashadecoste authored and lucafalasco committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    c190a2b View commit details
    Browse the repository at this point in the history

  2. v0.30.7

    @carbon-bot @lucafalasco
    carbon-bot authored and lucafalasco committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    b576875 View commit details
    Browse the repository at this point in the history

  3. Merge pull request carbon-design-system#529 from theiliad/tabular-dat… 

    …a-format

* add basic tabular data format support

* string updates

* finalize line graph implementation with tabular data support

* cleanup

* finalize scatter graph with support for tabular data

* commented out ideas for the data format

* time-series support for tabular data within line graph

* scatter support

* optimize logic to find main vertical & horizontal axes

* remove primary & secondary labels

* bubble chart support

* grouped bar support

* horizontal grouped bar

* fix legend filtering

* fix bubble and scatter

* fix bar hover errors

* simple bar support

* simple bar time-series support

* horizontal simple bar support

* more graph support

* fix pie tooltip

* fix donut center value

* fix line & scatter demo ranges

* fix bar demos

* stacked data supprot

* backwards data format compatibility

* fix plotting of datums with a value of 0

* fixed stacked bar tooltip

* remove primary, secondary, useAsGraphDomain/Range

* Update packages/core/src/model.ts

Co-Authored-By: natashadecoste <[email protected]>

* apply suggested PR changes

* fix group bar positioning issues

* apply PR suggested changes

* Update packages/core/demo/data/bar.ts

Co-Authored-By: natashadecoste <[email protected]>

* Update packages/core/demo/data/bar.ts

Co-Authored-By: natashadecoste <[email protected]>

* Update packages/core/demo/data/bar.ts

Co-Authored-By: natashadecoste <[email protected]>

* rename "identifier" to "mapsTo"

* add tutorials section to core storybook

* add links to errors

* remove unnecessary comment

* add custom color scale support

* apply PR suggested changes

* fix tests

Co-authored-by: natashadecoste <[email protected]>
    @theiliad @natashadecoste @lucafalasco
    2 people authored and lucafalasco committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    a643552 View commit details
    Browse the repository at this point in the history

  4. v0.30.8

    @carbon-bot @lucafalasco
    carbon-bot authored and lucafalasco committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    ff8b0aa View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into tooltip-enh

    @lucafalasco
    lucafalasco authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    7214aa5 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Eliad Moosavi <[email protected]>
    @lucafalasco @theiliad
    lucafalasco and theiliad committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    0247757 View commit details
    Browse the repository at this point in the history

  2. applied suggestions from review

    @lucafalasco
    lucafalasco committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    63687f9 View commit details
    Browse the repository at this point in the history

  3. fix ruler css

    @lucafalasco
    lucafalasco committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    ff48ac2 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Update packages/core/src/components/axes/ruler.ts 

    Co-Authored-By: Eliad Moosavi <[email protected]>
    @lucafalasco @theiliad
    lucafalasco and theiliad authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    db3d1f0 View commit details
    Browse the repository at this point in the history

  2. Update packages/core/src/styles/components/_ruler.scss 

    Co-Authored-By: Eliad Moosavi <[email protected]>
    @lucafalasco @theiliad
    lucafalasco and theiliad authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    fc4ff2a View commit details
    Browse the repository at this point in the history

  3. Update packages/core/src/components/axes/ruler.ts 

    Co-Authored-By: Eliad Moosavi <[email protected]>
    @lucafalasco @theiliad
    lucafalasco and theiliad authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    b4d5bf3 View commit details
    Browse the repository at this point in the history

  4. add suggestions from review

    @lucafalasco
    lucafalasco committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    ee1b29a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Update packages/core/demo/data/line.ts 

    Co-Authored-By: natashadecoste <[email protected]>
    @lucafalasco @natashadecoste
    lucafalasco and natashadecoste authored Apr 23, 2020
    Configuration menu
    Copy the full SHA
    d63e6a4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: natashadecoste <[email protected]>
    @lucafalasco @natashadecoste
    lucafalasco and natashadecoste authored Apr 23, 2020
    Configuration menu
    Copy the full SHA
    7ef4e63 View commit details
    Browse the repository at this point in the history

  3. enable ruler on bubble and scatter

    @lucafalasco
    lucafalasco committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    00c55e3 View commit details
    Browse the repository at this point in the history

  4. disable mouse listeners on grid

    @lucafalasco
    lucafalasco committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    2095c04 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. enable ruler for every scale type

    @lucafalasco
    lucafalasco committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    7a17802 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. fix ruler on linear scales, refactor matches logic

    @lucafalasco
    lucafalasco committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    ced86b4 View commit details
    Browse the repository at this point in the history