Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVT], StackedBarChart/ DonutChart/ LineChart, Elements that use 'role' must reference a valid WAI-ARIA role #634

Closed
PAnilReddy opened this issue May 22, 2020 · 9 comments · Fixed by #702
Assignees

Comments

@PAnilReddy
Copy link

Charts version
"@carbon/charts": "^0.30.10",

Elements that use 'role' must reference a valid WAI-ARIA role violations are seen in the 3 charts we use StackedBarChart/ DonutChart/ LineChart
23 violations in DonutChart( both empty state and with data)
26 violations in StackedBarChart( both empty state and with data)
8 violations in LineChart( both empty state and with data)

image

image

image

@theiliad
Copy link
Member

@PAnilReddy
Copy link
Author

@theiliad,
Well but the DAP shows it as error. Can you keep this open until we get the confirmation from accessibility team on the same and until we revert back.

@yinting-github
Copy link

@theiliad I retested it using DAP and IBM Accessibility Checker, it both report this error.
Would you mind to check the details under https://www.w3.org/TR/graphics-aria-1.0/#graphics-symbol, to see if any fixing can be implemented? Thanks.
Can we reopen this defect for tracking purpose?

@theiliad
Copy link
Member

@yinting-github as far as I can read into this page, the way we're using graphics-symbol is completely acceptable

image

If this is still an issue in DAP I'd suggest creating an issue in their repo or creating a support ticket etc.

@yinting-github
Copy link

yinting-github commented Jun 18, 2020

@theiliad we advised this specific issue to #accessibility-at-ibm team, and below are the comments:
You may need to post your code so we can review specifically what is the problem.
You probably need to add img to the role to support older user agents per the documentation in the green box note box.
Also add aria-label="Description of overall graphic" to provide a text description of the graphic as well.
I would generally follow the IBM Accessibility Checklist, as it is a slightly different (usually more conservative) set of standards than the w3 standards.
https://www.ibm.com/able/guidelines/ci162/accessibility_checklist.html

image

@yinting-github
Copy link

@theiliad Would you please reopen this defect so we can continue to track it? Thanks.

@theiliad
Copy link
Member

not sure if this is still relevant to us. yes looks like we might want to add an img role as fallback, but what's really broken here?

@pankaj-kumar34
Copy link

We are still facing this issue and should be reopened

@theiliad
Copy link
Member

We are still facing this issue and should be reopened

Hi 👋
As mentioned in the previous issue created, this is a DAP bug that we've reported to them and they've fixed.

#634

IBMa/equal-access#194

This isn't really a Carbon Charts issue, it'll happen with any SVGs with the DAP version you're using.
For further assistance I would:

  • update the DAP version you're using
  • reach out to DAP

I am not able to help at this point as those are valid WAI-ARIA roles that we're using 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants