Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min option is not working in simple bar charts #540

Closed
reeteshsingh93 opened this issue Mar 23, 2020 · 3 comments · Fixed by #713
Closed

Min option is not working in simple bar charts #540

reeteshsingh93 opened this issue Mar 23, 2020 · 3 comments · Fixed by #713

Comments

@reeteshsingh93
Copy link

I am submitting a...

  • Source code defect

charts version:

"@carbon/charts": "^0.24.3",
"@carbon/charts-react": "^0.24.3"

Issue description

Unable to define min tick value in simple bar charts.

We are trying to avoid decimal values in Y axis ticks:
image

We have tried using formatter with math.floor or ceil however since we have restricted the number of ticks to 5 it looks something like this which is not correct, so if we have any option where we can define domains if the calculated max range is less than 5 it might work

image

Current behavior

Round of the ticks value which repeats the value if the ticks decimal value is in same range.

Expected behavior

Value should not be repeated and it should be a whole number intead of decimal

@theiliad theiliad added contributor: accurat Work contributed by accurat type: enhancement 💡 and removed contributor: accurat Work contributed by accurat labels Mar 25, 2020
@reeteshsingh93
Copy link
Author

Is there any update on this?

@lruffing
Copy link

I need this functionality as well to avoid what's happening below.
decimal ticks not desired

Using formatter results in:
too many ticks

@reeteshsingh93
Copy link
Author

Is there any update on this?

natashadecoste added a commit to natashadecoste/carbon-charts that referenced this issue Jul 17, 2020
@natashadecoste natashadecoste mentioned this issue Jul 17, 2020
8 tasks
theiliad added a commit that referenced this issue Jul 21, 2020
* chore(angular): add angular 9 dependency versions to peerDependencies

* improvement(core): add functionality for custom tick values being passed in

fix #540

* add time series demo

* fix label scale

* update demo

* review changes

Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Fei Z <[email protected]>
linhenry0417 pushed a commit to linhenry0417/carbon-charts that referenced this issue Jul 23, 2020
* chore(angular): add angular 9 dependency versions to peerDependencies

* improvement(core): add functionality for custom tick values being passed in

fix carbon-design-system#540

* add time series demo

* fix label scale

* update demo

* review changes

Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Fei Z <[email protected]>
theiliad added a commit that referenced this issue Jul 27, 2020
* adjust the bar width to prevent bars from overlapping

* adjust the bar width to prevent bars from overlapping

* add demo

* revise based on code review

* revise based on code review

* revise based on code review

* adjust the bar width to prevent bars from overlapping

* adjust the bar width to prevent bars from overlapping

* add demo

* revise based on code review

* fix: fix missing title option in charts interface

* v0.32.1

* fix(core, angular, react, vue, svelte): fix scatter graph data updates (#654)

* Merge pull request #656 from theiliad/update-demo-data

* chore(core, react, angular, vue, svelte): update demo data

* update angular storybook demos

* Update packages/core/demo/data/index.ts

Co-authored-by: Donisius Wigie <[email protected]>

* Update packages/core/demo/data/index.ts

Co-authored-by: Donisius Wigie <[email protected]>

* v0.32.2

* chore(core, react, angular, vue, svelte): fix codesandbox examples

* v0.32.3

* Update README.md

* Update index.ts

* fix: update tslint and prettier options (#661)

- add packages/core/.prettierrc
- add packages/vue/.prettierignore
- update packages/core/.prettierignore
- update packages/core/tslint.json

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.4

* Merge pull request #549 from accurat/area-chart

* add area chart component - basic

* feat(core): Axes configuration options defaultable, Add option to not include 0 on axes

* add area chart component - basic

* Merge pull request #464 from accurat/storybook-in-core

* Storybook in core: Configuration almost done

* Storybook in core: Add examples (WIP)

* Storybook in core: Fix styles.scss require

* Storybook in core: Rename variables

* Storybook in core: Filter the list of { options, data } cases from the demo ones adding an isDemoExample boolean: only those will be visible in the demo page, the rest will only be visible in the storybooks

* add vanilla codesandbox

* Storybook in core: Minor changes

* fix vanilla sandbox issue

* remove core internal demo site

* globalize all demo styling within core

* fix core story file path

* add one page demo story

* addition of themes to the core storybook

* fix storybook build

* remove unnecessary import from storybooks

* downgrade sass version

* fix tests

* add correct NODE_ENV var in the netlify script

* fix tests on Travis

* fix tests

* add correct classname to wrapper storybooks

* add welcome story

* update storybook default theme

Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: carbon-bot <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Adam Rybinski <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* fix merge upstream

* Fix area options merge

* basic stacked area chart

* remove spacing

* add legend item hover

* refactor

* add event listeners

* hide tooltip for now, clean up not used imports

* fix rebase

* add mix-blend-mode

* rename area > stacked-area

* Fix area-stacked scss

* remove stroke

* fix rebase, use model.getStackedData

* fix spaceOnEdges

* update area data to tabular format

* fix legend highlighting

* add area stacked percentage

* add lines to stacked area chart

* add ruler and tooltip

* add wrappers for stacked area chart

* hide lines when filtering is active

* feat(core, react, vue, angular): add stacked area chart

* format code

* fix react wrapper for stacked area

* fix import for svelte stacked area

* add fade-in flag in scatter graph

* format

* format

Co-authored-by: Serena Girardi <[email protected]>
Co-authored-by: Ilaria Venturini <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: carbon-bot <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Adam Rybinski <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.5

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Merge pull request #652 from navjeets/master

* fix(scatter): multi-tooltip doesn't show on hover over data points

#650

* fix(scatter): multi-tooltip doesn't show on hover over data points

* fix(scatter): multi-tooltip doesn't show on hover over data points

#650

* Changelog

* fix(scatter): multi-tooltip doesn't show on hover over data points

#650

* Update scatter.ts

* fix(scatter): multi-tooltip doesn't show on hover over data points

#650

* fix(scatter): multi-tooltip doesn't show on hover over data points

#650

* Update scatter.ts

* fix(scatter): multi-tooltip doesn't show on hover over data points

#650

* Update scatter.ts

* resolved conflicts with master

Co-authored-by: NAVJEET SANDHU <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.6

* Fix charts render data outside custom domain (#666)

* fix: remove data outside custom domain

* fix: fix ticks on charts for custom domain

* refactor: add demo for custom domain

* refactor: create custom domain demos

Co-authored-by: Fei <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* Update line.ts

* Merge pull request #669 from carmiele/issue-668-missing-timescale-option

Co-authored-by: Carmen Tan <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.7

* Merge pull request #672 from sophiiae/fixAreaPercentage

* fix: fix AreaPercentageChart domain issue

* style: remove unused imports

* fix: replace mapsTo with ScaleType

* fix: check mapsTo in the axesOptions

* style: format the code

* style(n): refactor code

* fix: remove Tools.clone for copying demo data and options

* style: format code

* fix: fix extra space error on stacked area percentage chart

* improvement: add percentage option in AxisOptions

Add percentage as a flag under AxisOptions for percentage chart with default [0, 100] axis domain.
Add missing stacked option in AxisOptions interface.

* style: update comments

* style: update comments

Co-authored-by: Fei <[email protected]>

* v0.32.8

* remove duplicated demos

* Merge pull request #623 from natashadecoste/guage

* created gauge chart - squashed

* added to react

* added to all packages

* resized gauge, corrected colors

* fixed tooltip

* two stories for gauge: circular and semicircular

* hidden legend

* changed perc symbol size and position, also gauge size

* distance between numbers

* last fix for text size

* carets with svgs

* fixed pixel and dominant baseline for firefox

* centers caret for firefox

* fixed caret size and position

* adapts number size with changing of the size of the chart itself

* better handling of higher arcRatios

* Remove arcRatio, add gauge "type"

* Fix sizing and centering of gauge chart

* Fix option typings for Gauge chart

* Reorganize all sizing and positioning calculations, Simplify data format

* Make Gauge colors customizable from options

* Gauge: Optical centering of the center number for the presence of the % small symbol

* Gauge: Add configuration option for arrow color

* Gauge type is now defaulted in configuration.ts

* Fixed data format, removed tooltip service

* Gauge: Clamp the arc at 100%

* Revert "Update CHANGELOG.md"

This reverts commit cce62aa.

* remove changelog diff

* update guage

* formatting

* review changes

* add status, arrow direction, theme & remove spacer

* fix guage to work without delta

* add enter/merge/exit for value and delta

* Update packages/core/src/components/graphs/gauge.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* Update packages/core/src/configuration.ts

Co-authored-by: Donisius Wigie <[email protected]>

* review changes

* Update packages/core/src/components/graphs/gauge.ts

Co-authored-by: Donisius Wigie <[email protected]>

* review comments + prettier

* review changes

* update config names

* feat(gauge chart): add gauge chart to carbon-charts

re #554

* review changes

Co-authored-by: Luca Mattiazzi <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Donisius Wigie <[email protected]>

* v0.32.9

* fix(core): fix gauge charts without a delta number (#680)

* Merge pull request #646 from linhenry0417/truncate-label

* truncate label if too long to avoid graph display issue

* truncate label if too long to avoid graph display issue

* truncate label if too long to avoid graph display issue

* truncate label if too long to avoid graph display issue

* refactor

* add demo

* add demo for long label

* change variables naming

* code refactor

* add truncation function to options

* add truncation function to tools

* code refactor

* fix demo data

* refactor based on code review

* refactor based on code review

* refactor based on code review

* refactor based on code review

* refactor based on code review

* add line chart demo

* fix truncation interface

* add scatter demo for long label truncation

* fix legend text alignment and default config loading

* add legend truncation config in demo option

* fix filter label display issue

* code refactor

* code refactor

* code refactor

* code refactor

* remove unnecessary import in tooltip-bar.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.10

* Update README.md

* Fix stacked area chart with uneven data (#681)

* fix: fix stacked area chart with uneven data

sort stackKeys

* style: remove console.log

* improvement: add demo for uneven data and revise code

* Update packages/core/src/model.ts

Co-authored-by: Donisius Wigie <[email protected]>

* style: add semicolons and revert code

Co-authored-by: Fei <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Donisius Wigie <[email protected]>

* Merge pull request #682 from natashadecoste/gauge-tooltip

tooltip is needed for title truncation

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.11

* Merge pull request #678 from natashadecoste/area-chart-stroke

* fix(core): stroke dissappears when remapping the dimensions

* fix mapping custom domain and range identifiers

* fix for group remapping

* v0.32.12

* Update README.md

* feat(svelte): add Gauge chart wrapper (#686)

* chore(angular): add angular 9 dependency versions to peerDependencies (#690)

* Respect addSpaceOnEdges when initializing axes (#688)

* fix(core): respect addSpaceOnEdges when initializing axes

* format

* PR changes

* format

* Merge pull request #639 from sophiiae/selectedGroups

* Add selectedGroups option

* Bind selectedGroups with legend and dataGroups

* improvement: move selectedGroup under data option

re #610

* refactor: update selectedGroup position

* improvement: grab options from getOptions

* improvement: fix naming and update comments

* improvement: simplify the code

* improvement: remove updateSelectedGroups

* fix: remove updateSelectedGroups from legend

* test: add unit test for setting up selectedGroups

* test: modify unit test

* test: renaming

* test: revise unit test

* test: update test description

* style: revise the comment for selectedGroup

* test: update test

* test: simplify the test code

* style: format the code

* test: add more tests

* test: remove tests for events

* test: remove async function

* fix: fix check mark position issue and add demos

* fix: fix multiple check marks bug

* fix: fix chart shrinks between legend click for selected groups

* fix: fix legend height change with first legend click

* fix: fix demo broken

* refactor: renaming

* refactor: get legend height

* remove semicolon

Co-authored-by: Eliad Moosavi <[email protected]>

* fix: fix data domain

* refactor: rename the demo

* fix: fix angular and react height issue

Co-authored-by: Fei <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.33.0

* fix: fix bar chart tooltip data (#692)

Co-authored-by: Fei <[email protected]>

* Merge pull request #694 from sophiiae/remove-primary-secondary

* refactor: remove primary and secondary option from demo

* style: remove commas

Co-authored-by: Fei <[email protected]>

* v0.33.1

* fix:(core): Scatter points fix (#703)

* chore(angular): add angular 9 dependency versions to peerDependencies

* fix(core): fix scatter points color and opacity

fix #469

* fix theming for scatter points

Co-authored-by: Eliad Moosavi <[email protected]>

* improvement(skeleton): honour loading config to show skeleton chart (#691)

* improvement(skeleton): honour loading config to show skeleton chart even when data is passed in

fix #677

* Update packages/core/src/components/axes/axis.ts

Co-authored-by: Eliad Moosavi <[email protected]>

Co-authored-by: Eliad Moosavi <[email protected]>

* fix: add role fallback value for legend (#702)

Co-authored-by: Fei <[email protected]>

* feat(core): add title element to main SVG (#704)

* feat(core, angular, vue, react, svelte): add title element to main SVG

* format

* Merge pull request #695 from theiliad/tooltip-redesign

* single tooltip enhancement

* remove old toolips from axis chart types

* add tooltips for all chart types

* add total value to tooltips

* add ruler to stacked bar charts

* feat(core, angular, vue, react, svelte): tooltip redesign

* upgrade axis truncated label tooltips to the new style

* fix stacked bar tooltip order

* format

* v0.34.0

* fix(core, react, angular, vue, svelte): render both vertical and horizontal thresholds (#706)

* Merge pull request #705 from theiliad/angular-zone-js-vupdate

* v0.34.1

* Fix hidden axes for charts (#701)

* fix: fix render skeleton for charts

* fix: update condition for skeleton

Co-authored-by: Fei <[email protected]>

* Merge pull request #707 from sophiiae/wai-aria-label

* improvement: improve accessibility with aria-labels

* style: remove extra line

Co-authored-by: Fei <[email protected]>

* v0.34.2

* revise based on code review

* Merge pull request #425 from natashadecoste/meter-chart

* meter chart and graph

* add support for percentage value in title

* change data on demo

* fix demo update data

* add status indicator

* transition bar

* update the chart holder for meter

* add tooltip in to support title truncation

* fix the title truncation tooltip & demo container

* fix title truncation stack overflow on meter title

* update the status indicator width calc

* border style

* update to allow meter to add a default chart title

* add check for peak within domain

* Update packages/core/demo/index.ts

Co-Authored-By: Eliad Moosavi <[email protected]>

* review changes

* remove duplicate

* update demo

* fix legend enabled option to affect legend spacer

* fix meter options

* fix demo height

* remove console log

* fix lint err

* separate options out from data

* merge with new changes

* update meter status indicator

* fix meter title

* add vue wrapper

* add angular wrappers

* react wrappers

* add demo example

* update to the peak functionality

* update to percentage value style

* update meter to tabular format

* bars to use status color

* add in border

* fix firefox errors

* move chart status to meter model

* update to the look of the bar and spacing

* fix title tooltip

* add in custom color

* update icons + cleanup

* update styles on meter border

* a11y

* update meter specs

* fix icons

* remove long names from demos

* fix pie tooltip

* cleanup

* fix meteroptions

* cleanup charts/axis-charts

* remove peak if there is none

* review changes

* reivew changes/demo size fix

* remove truncated tooltip for title

* fix meter title truncation

* fix chart without height taking too much space

* Update packages/core/src/components/graphs/meter.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* Update packages/core/src/components/graphs/meter.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* Update packages/core/src/components/graphs/meter.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* review changes

* check max height

* review changes

* update config

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.34.3

* Custom tick values (#713)

* chore(angular): add angular 9 dependency versions to peerDependencies

* improvement(core): add functionality for custom tick values being passed in

fix #540

* add time series demo

* fix label scale

* update demo

* review changes

Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Fei Z <[email protected]>

* Merge pull request #710 from sophiiae/pie-align-center

* improvement: align center flag for non-axis charts and legend

* style: formatting the code

* fix: fix centering offset for pie

* improvement: use enum for chart and legend alignment

add enum, set default alignment, add center and right alignment for non-axis charts and legend

Co-authored-by: Fei <[email protected]>

* v0.34.4

* fix: fix pie chart alignment (#716)

Co-authored-by: Fei <[email protected]>

* Remove space on edge on custom domain (#715)

* fix: remove space on edge on custom domain

* fix: keep labels on the edges for custom domain

Co-authored-by: Fei <[email protected]>

* Merge pull request #709 from theiliad/fix-stacked-bar-tooltip-lag

* fix(core, angular, vue, react, svelte): debounce ruler renders when more than 100 datapoints

* format

Co-authored-by: Fei Z <[email protected]>

* v0.34.5

* revise based on code review

* revise based on code review

* revise based on code review

Co-authored-by: Fei Z <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Fei <[email protected]>
Co-authored-by: carbon-bot <[email protected]>
Co-authored-by: Donisius Wigie <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Eric Yang <[email protected]>
Co-authored-by: Luca Falasco <[email protected]>
Co-authored-by: Serena Girardi <[email protected]>
Co-authored-by: Ilaria Venturini <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Adam Rybinski <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Navjeet Sandhu <[email protected]>
Co-authored-by: NAVJEET SANDHU <[email protected]>
Co-authored-by: Carmen Tan <[email protected]>
Co-authored-by: Carmen Tan <[email protected]>
Co-authored-by: natashadecoste <[email protected]>
Co-authored-by: Luca Mattiazzi <[email protected]>
Co-authored-by: Eric Liu <[email protected]>
theiliad added a commit to theiliad/carbon-charts that referenced this issue May 17, 2021
* chore(angular): add angular 9 dependency versions to peerDependencies

* improvement(core): add functionality for custom tick values being passed in

fix carbon-design-system#540

* add time series demo

* fix label scale

* update demo

* review changes

Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Fei Z <[email protected]>
theiliad added a commit to theiliad/carbon-charts that referenced this issue May 17, 2021
…system#711)

* adjust the bar width to prevent bars from overlapping

* adjust the bar width to prevent bars from overlapping

* add demo

* revise based on code review

* revise based on code review

* revise based on code review

* adjust the bar width to prevent bars from overlapping

* adjust the bar width to prevent bars from overlapping

* add demo

* revise based on code review

* fix: fix missing title option in charts interface

* v0.32.1

* fix(core, angular, react, vue, svelte): fix scatter graph data updates (carbon-design-system#654)

* Merge pull request carbon-design-system#656 from theiliad/update-demo-data

* chore(core, react, angular, vue, svelte): update demo data

* update angular storybook demos

* Update packages/core/demo/data/index.ts

Co-authored-by: Donisius Wigie <[email protected]>

* Update packages/core/demo/data/index.ts

Co-authored-by: Donisius Wigie <[email protected]>

* v0.32.2

* chore(core, react, angular, vue, svelte): fix codesandbox examples

* v0.32.3

* Update README.md

* Update index.ts

* fix: update tslint and prettier options (carbon-design-system#661)

- add packages/core/.prettierrc
- add packages/vue/.prettierignore
- update packages/core/.prettierignore
- update packages/core/tslint.json

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.4

* Merge pull request carbon-design-system#549 from accurat/area-chart

* add area chart component - basic

* feat(core): Axes configuration options defaultable, Add option to not include 0 on axes

* add area chart component - basic

* Merge pull request carbon-design-system#464 from accurat/storybook-in-core

* Storybook in core: Configuration almost done

* Storybook in core: Add examples (WIP)

* Storybook in core: Fix styles.scss require

* Storybook in core: Rename variables

* Storybook in core: Filter the list of { options, data } cases from the demo ones adding an isDemoExample boolean: only those will be visible in the demo page, the rest will only be visible in the storybooks

* add vanilla codesandbox

* Storybook in core: Minor changes

* fix vanilla sandbox issue

* remove core internal demo site

* globalize all demo styling within core

* fix core story file path

* add one page demo story

* addition of themes to the core storybook

* fix storybook build

* remove unnecessary import from storybooks

* downgrade sass version

* fix tests

* add correct NODE_ENV var in the netlify script

* fix tests on Travis

* fix tests

* add correct classname to wrapper storybooks

* add welcome story

* update storybook default theme

Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: carbon-bot <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Adam Rybinski <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* fix merge upstream

* Fix area options merge

* basic stacked area chart

* remove spacing

* add legend item hover

* refactor

* add event listeners

* hide tooltip for now, clean up not used imports

* fix rebase

* add mix-blend-mode

* rename area > stacked-area

* Fix area-stacked scss

* remove stroke

* fix rebase, use model.getStackedData

* fix spaceOnEdges

* update area data to tabular format

* fix legend highlighting

* add area stacked percentage

* add lines to stacked area chart

* add ruler and tooltip

* add wrappers for stacked area chart

* hide lines when filtering is active

* feat(core, react, vue, angular): add stacked area chart

* format code

* fix react wrapper for stacked area

* fix import for svelte stacked area

* add fade-in flag in scatter graph

* format

* format

Co-authored-by: Serena Girardi <[email protected]>
Co-authored-by: Ilaria Venturini <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: carbon-bot <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Adam Rybinski <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.5

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Merge pull request carbon-design-system#652 from navjeets/master

* fix(scatter): multi-tooltip doesn't show on hover over data points

carbon-design-system#650

* fix(scatter): multi-tooltip doesn't show on hover over data points

* fix(scatter): multi-tooltip doesn't show on hover over data points

carbon-design-system#650

* Changelog

* fix(scatter): multi-tooltip doesn't show on hover over data points

carbon-design-system#650

* Update scatter.ts

* fix(scatter): multi-tooltip doesn't show on hover over data points

carbon-design-system#650

* fix(scatter): multi-tooltip doesn't show on hover over data points

carbon-design-system#650

* Update scatter.ts

* fix(scatter): multi-tooltip doesn't show on hover over data points

carbon-design-system#650

* Update scatter.ts

* resolved conflicts with master

Co-authored-by: NAVJEET SANDHU <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.6

* Fix charts render data outside custom domain (carbon-design-system#666)

* fix: remove data outside custom domain

* fix: fix ticks on charts for custom domain

* refactor: add demo for custom domain

* refactor: create custom domain demos

Co-authored-by: Fei <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* Update line.ts

* Merge pull request carbon-design-system#669 from carmiele/issue-668-missing-timescale-option

Co-authored-by: Carmen Tan <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.7

* Merge pull request carbon-design-system#672 from sophiiae/fixAreaPercentage

* fix: fix AreaPercentageChart domain issue

* style: remove unused imports

* fix: replace mapsTo with ScaleType

* fix: check mapsTo in the axesOptions

* style: format the code

* style(n): refactor code

* fix: remove Tools.clone for copying demo data and options

* style: format code

* fix: fix extra space error on stacked area percentage chart

* improvement: add percentage option in AxisOptions

Add percentage as a flag under AxisOptions for percentage chart with default [0, 100] axis domain.
Add missing stacked option in AxisOptions interface.

* style: update comments

* style: update comments

Co-authored-by: Fei <[email protected]>

* v0.32.8

* remove duplicated demos

* Merge pull request carbon-design-system#623 from natashadecoste/guage

* created gauge chart - squashed

* added to react

* added to all packages

* resized gauge, corrected colors

* fixed tooltip

* two stories for gauge: circular and semicircular

* hidden legend

* changed perc symbol size and position, also gauge size

* distance between numbers

* last fix for text size

* carets with svgs

* fixed pixel and dominant baseline for firefox

* centers caret for firefox

* fixed caret size and position

* adapts number size with changing of the size of the chart itself

* better handling of higher arcRatios

* Remove arcRatio, add gauge "type"

* Fix sizing and centering of gauge chart

* Fix option typings for Gauge chart

* Reorganize all sizing and positioning calculations, Simplify data format

* Make Gauge colors customizable from options

* Gauge: Optical centering of the center number for the presence of the % small symbol

* Gauge: Add configuration option for arrow color

* Gauge type is now defaulted in configuration.ts

* Fixed data format, removed tooltip service

* Gauge: Clamp the arc at 100%

* Revert "Update CHANGELOG.md"

This reverts commit cce62aa.

* remove changelog diff

* update guage

* formatting

* review changes

* add status, arrow direction, theme & remove spacer

* fix guage to work without delta

* add enter/merge/exit for value and delta

* Update packages/core/src/components/graphs/gauge.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* Update packages/core/src/configuration.ts

Co-authored-by: Donisius Wigie <[email protected]>

* review changes

* Update packages/core/src/components/graphs/gauge.ts

Co-authored-by: Donisius Wigie <[email protected]>

* review comments + prettier

* review changes

* update config names

* feat(gauge chart): add gauge chart to carbon-charts

re carbon-design-system#554

* review changes

Co-authored-by: Luca Mattiazzi <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Donisius Wigie <[email protected]>

* v0.32.9

* fix(core): fix gauge charts without a delta number (carbon-design-system#680)

* Merge pull request carbon-design-system#646 from linhenry0417/truncate-label

* truncate label if too long to avoid graph display issue

* truncate label if too long to avoid graph display issue

* truncate label if too long to avoid graph display issue

* truncate label if too long to avoid graph display issue

* refactor

* add demo

* add demo for long label

* change variables naming

* code refactor

* add truncation function to options

* add truncation function to tools

* code refactor

* fix demo data

* refactor based on code review

* refactor based on code review

* refactor based on code review

* refactor based on code review

* refactor based on code review

* add line chart demo

* fix truncation interface

* add scatter demo for long label truncation

* fix legend text alignment and default config loading

* add legend truncation config in demo option

* fix filter label display issue

* code refactor

* code refactor

* code refactor

* code refactor

* remove unnecessary import in tooltip-bar.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.10

* Update README.md

* Fix stacked area chart with uneven data (carbon-design-system#681)

* fix: fix stacked area chart with uneven data

sort stackKeys

* style: remove console.log

* improvement: add demo for uneven data and revise code

* Update packages/core/src/model.ts

Co-authored-by: Donisius Wigie <[email protected]>

* style: add semicolons and revert code

Co-authored-by: Fei <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Donisius Wigie <[email protected]>

* Merge pull request carbon-design-system#682 from natashadecoste/gauge-tooltip

tooltip is needed for title truncation

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.32.11

* Merge pull request carbon-design-system#678 from natashadecoste/area-chart-stroke

* fix(core): stroke dissappears when remapping the dimensions

* fix mapping custom domain and range identifiers

* fix for group remapping

* v0.32.12

* Update README.md

* feat(svelte): add Gauge chart wrapper (carbon-design-system#686)

* chore(angular): add angular 9 dependency versions to peerDependencies (carbon-design-system#690)

* Respect addSpaceOnEdges when initializing axes (carbon-design-system#688)

* fix(core): respect addSpaceOnEdges when initializing axes

* format

* PR changes

* format

* Merge pull request carbon-design-system#639 from sophiiae/selectedGroups

* Add selectedGroups option

* Bind selectedGroups with legend and dataGroups

* improvement: move selectedGroup under data option

re carbon-design-system#610

* refactor: update selectedGroup position

* improvement: grab options from getOptions

* improvement: fix naming and update comments

* improvement: simplify the code

* improvement: remove updateSelectedGroups

* fix: remove updateSelectedGroups from legend

* test: add unit test for setting up selectedGroups

* test: modify unit test

* test: renaming

* test: revise unit test

* test: update test description

* style: revise the comment for selectedGroup

* test: update test

* test: simplify the test code

* style: format the code

* test: add more tests

* test: remove tests for events

* test: remove async function

* fix: fix check mark position issue and add demos

* fix: fix multiple check marks bug

* fix: fix chart shrinks between legend click for selected groups

* fix: fix legend height change with first legend click

* fix: fix demo broken

* refactor: renaming

* refactor: get legend height

* remove semicolon

Co-authored-by: Eliad Moosavi <[email protected]>

* fix: fix data domain

* refactor: rename the demo

* fix: fix angular and react height issue

Co-authored-by: Fei <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>

* v0.33.0

* fix: fix bar chart tooltip data (carbon-design-system#692)

Co-authored-by: Fei <[email protected]>

* Merge pull request carbon-design-system#694 from sophiiae/remove-primary-secondary

* refactor: remove primary and secondary option from demo

* style: remove commas

Co-authored-by: Fei <[email protected]>

* v0.33.1

* fix:(core): Scatter points fix (carbon-design-system#703)

* chore(angular): add angular 9 dependency versions to peerDependencies

* fix(core): fix scatter points color and opacity

fix carbon-design-system#469

* fix theming for scatter points

Co-authored-by: Eliad Moosavi <[email protected]>

* improvement(skeleton): honour loading config to show skeleton chart (carbon-design-system#691)

* improvement(skeleton): honour loading config to show skeleton chart even when data is passed in

fix carbon-design-system#677

* Update packages/core/src/components/axes/axis.ts

Co-authored-by: Eliad Moosavi <[email protected]>

Co-authored-by: Eliad Moosavi <[email protected]>

* fix: add role fallback value for legend (carbon-design-system#702)

Co-authored-by: Fei <[email protected]>

* feat(core): add title element to main SVG (carbon-design-system#704)

* feat(core, angular, vue, react, svelte): add title element to main SVG

* format

* Merge pull request carbon-design-system#695 from theiliad/tooltip-redesign

* single tooltip enhancement

* remove old toolips from axis chart types

* add tooltips for all chart types

* add total value to tooltips

* add ruler to stacked bar charts

* feat(core, angular, vue, react, svelte): tooltip redesign

* upgrade axis truncated label tooltips to the new style

* fix stacked bar tooltip order

* format

* v0.34.0

* fix(core, react, angular, vue, svelte): render both vertical and horizontal thresholds (carbon-design-system#706)

* Merge pull request carbon-design-system#705 from theiliad/angular-zone-js-vupdate

* v0.34.1

* Fix hidden axes for charts (carbon-design-system#701)

* fix: fix render skeleton for charts

* fix: update condition for skeleton

Co-authored-by: Fei <[email protected]>

* Merge pull request carbon-design-system#707 from sophiiae/wai-aria-label

* improvement: improve accessibility with aria-labels

* style: remove extra line

Co-authored-by: Fei <[email protected]>

* v0.34.2

* revise based on code review

* Merge pull request carbon-design-system#425 from natashadecoste/meter-chart

* meter chart and graph

* add support for percentage value in title

* change data on demo

* fix demo update data

* add status indicator

* transition bar

* update the chart holder for meter

* add tooltip in to support title truncation

* fix the title truncation tooltip & demo container

* fix title truncation stack overflow on meter title

* update the status indicator width calc

* border style

* update to allow meter to add a default chart title

* add check for peak within domain

* Update packages/core/demo/index.ts

Co-Authored-By: Eliad Moosavi <[email protected]>

* review changes

* remove duplicate

* update demo

* fix legend enabled option to affect legend spacer

* fix meter options

* fix demo height

* remove console log

* fix lint err

* separate options out from data

* merge with new changes

* update meter status indicator

* fix meter title

* add vue wrapper

* add angular wrappers

* react wrappers

* add demo example

* update to the peak functionality

* update to percentage value style

* update meter to tabular format

* bars to use status color

* add in border

* fix firefox errors

* move chart status to meter model

* update to the look of the bar and spacing

* fix title tooltip

* add in custom color

* update icons + cleanup

* update styles on meter border

* a11y

* update meter specs

* fix icons

* remove long names from demos

* fix pie tooltip

* cleanup

* fix meteroptions

* cleanup charts/axis-charts

* remove peak if there is none

* review changes

* reivew changes/demo size fix

* remove truncated tooltip for title

* fix meter title truncation

* fix chart without height taking too much space

* Update packages/core/src/components/graphs/meter.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* Update packages/core/src/components/graphs/meter.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* Update packages/core/src/components/graphs/meter.ts

Co-authored-by: Eliad Moosavi <[email protected]>

* review changes

* check max height

* review changes

* update config

Co-authored-by: Eliad Moosavi <[email protected]>

* v0.34.3

* Custom tick values (carbon-design-system#713)

* chore(angular): add angular 9 dependency versions to peerDependencies

* improvement(core): add functionality for custom tick values being passed in

fix carbon-design-system#540

* add time series demo

* fix label scale

* update demo

* review changes

Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Fei Z <[email protected]>

* Merge pull request carbon-design-system#710 from sophiiae/pie-align-center

* improvement: align center flag for non-axis charts and legend

* style: formatting the code

* fix: fix centering offset for pie

* improvement: use enum for chart and legend alignment

add enum, set default alignment, add center and right alignment for non-axis charts and legend

Co-authored-by: Fei <[email protected]>

* v0.34.4

* fix: fix pie chart alignment (carbon-design-system#716)

Co-authored-by: Fei <[email protected]>

* Remove space on edge on custom domain (carbon-design-system#715)

* fix: remove space on edge on custom domain

* fix: keep labels on the edges for custom domain

Co-authored-by: Fei <[email protected]>

* Merge pull request carbon-design-system#709 from theiliad/fix-stacked-bar-tooltip-lag

* fix(core, angular, vue, react, svelte): debounce ruler renders when more than 100 datapoints

* format

Co-authored-by: Fei Z <[email protected]>

* v0.34.5

* revise based on code review

* revise based on code review

* revise based on code review

Co-authored-by: Fei Z <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Fei <[email protected]>
Co-authored-by: carbon-bot <[email protected]>
Co-authored-by: Donisius Wigie <[email protected]>
Co-authored-by: Eliad Moosavi <[email protected]>
Co-authored-by: Eric Yang <[email protected]>
Co-authored-by: Luca Falasco <[email protected]>
Co-authored-by: Serena Girardi <[email protected]>
Co-authored-by: Ilaria Venturini <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Cal Smith <[email protected]>
Co-authored-by: Adam Rybinski <[email protected]>
Co-authored-by: cesare.soldini <[email protected]>
Co-authored-by: Navjeet Sandhu <[email protected]>
Co-authored-by: NAVJEET SANDHU <[email protected]>
Co-authored-by: Carmen Tan <[email protected]>
Co-authored-by: Carmen Tan <[email protected]>
Co-authored-by: natashadecoste <[email protected]>
Co-authored-by: Luca Mattiazzi <[email protected]>
Co-authored-by: Eric Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants