Skip to content

Commit

Permalink
fix(tooltip): need to pass the datum along with the tooltip calls
Browse files Browse the repository at this point in the history
  • Loading branch information
scottdickerson committed Nov 6, 2019
1 parent f367f83 commit 3bd7bfc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/core/src/components/essentials/tooltip-bar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export class TooltipBar extends Tooltip {
const formattedValue = Tools.getProperty(this.model.getOptions(), "tooltip", "valueFormatter") ?
this.model.getOptions().tooltip.valueFormatter(datapoint.value) : datapoint.value.toLocaleString("en");

const indicatorColor = this.model.getStrokeColor(datapoint.datasetLabel, datapoint.label, datapoint.value);
const indicatorColor = this.model.getStrokeColor(datapoint.datasetLabel, datapoint.label, datapoint.value, datapoint);

return `
<li>
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/essentials/tooltip-scatter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export class TooltipScatter extends Tooltip {
const formattedValue = Tools.getProperty(this.model.getOptions(), "tooltip", "valueFormatter") ?
this.model.getOptions().tooltip.valueFormatter(data.value) : data.value.toLocaleString("en");

const indicatorColor = this.model.getStrokeColor(data.datasetLabel, data.label, data.value);
const indicatorColor = this.model.getStrokeColor(data.datasetLabel, data.label, data.value, data);

return `
<div class="datapoint-tooltip">
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/essentials/tooltip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class Tooltip extends Component {
const formattedValue = Tools.getProperty(this.model.getOptions(), "tooltip", "valueFormatter") ?
this.model.getOptions().tooltip.valueFormatter(datapointValue) : datapointValue.toLocaleString("en");

const indicatorColor = this.model.getStrokeColor(datapoint.datasetLabel, datapoint.label);
const indicatorColor = this.model.getStrokeColor(datapoint.datasetLabel, datapoint.label, datapoint.value, datapoint);

return `
<li>
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/graphs/scatter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export class Scatter extends Component {
const hoveredElement = select(this);
hoveredElement.classed("hovered", true);

hoveredElement.style("fill", (d: any) => self.model.getFillColor(d.datasetLabel, d.label, d.value));
hoveredElement.style("fill", (d: any) => self.model.getFillColor(d.datasetLabel, d.label, d.value, d));

// Show tooltip
self.services.events.dispatchEvent("show-tooltip", {
Expand Down

0 comments on commit 3bd7bfc

Please sign in to comment.