fix(ui): Revert upgrade to react-lazylog #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
force-pushed
the
revert_upgrade_to_react_lazylog
branch
from
accef8f to
4a6e483
Compare
leonlnj
approved these changes
Jul 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 68.06% 62.27% -5.79%
==========================================
Files 149 124 -25
Lines 11809 9774 -2035
==========================================
- Hits 8038 6087 -1951
+ Misses 3033 2949 -84
Partials 738 738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deadlycoconuts
commented
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For some still yet to be understood reason, replacing the forked version of
react-lazylogfrom https://github.com/gojekfarm/react-lazylog#master with the latest official version of the same package caused the logs viewer to crash due to some styling issues that get triggered when we manually set the height of the logs viewer (or the component containing it):In the Turing UI, this height is set by the custom style in
PodLogsViewer.scss(removed in this PR) while in the Merlin UI, it is set by passing it as a prop to theLazyLogcomponent. This PR also standardises the way both UIs are setting this value.Strangely enough, the Merlin UI isn't experiencing these styling issues even after having its
react-lazylogreplaced with the official version but a deeper look into this will be done at a later time.