fix: Prevent calls to ensembling job service/controllers if batch ensembling is deactivated #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When an ensembler gets deleted, checks are performed to see if there are any associated ensembling jobs that use it. However, these checks are unnecessary and should not be performed if batch ensembling has been deactivated in the first place. Doing so triggers bugs and other errors because the ensembling job service or controllers wouldn't be initialised during start up of the Turing API server.
This PR thus introduces some additional checks to ensure that these checks are skipped if batch ensembling is turned off, so as to prevent such bugs: