Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent calls to ensembling job service/controllers if batch ensembling is deactivated #356

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Aug 2, 2023

Context

When an ensembler gets deleted, checks are performed to see if there are any associated ensembling jobs that use it. However, these checks are unnecessary and should not be performed if batch ensembling has been deactivated in the first place. Doing so triggers bugs and other errors because the ensembling job service or controllers wouldn't be initialised during start up of the Turing API server.

This PR thus introduces some additional checks to ensure that these checks are skipped if batch ensembling is turned off, so as to prevent such bugs:

  • on the UI level: prevent the ensembler deletion pop up from sending any requests to the Turing API server to retrieve a list of related ensembling jobs if batch ensembling is turned off
    image
  • on the API level: prevent the delete ensembler handler from using the ensembling job service to retrieve ensembling jobs if batch ensembling is turned off

@deadlycoconuts deadlycoconuts self-assigned this Aug 2, 2023
@deadlycoconuts deadlycoconuts force-pushed the hide_job_related_checks_when_inactive branch from bed91c0 to 42bea90 Compare August 2, 2023 09:21
@deadlycoconuts deadlycoconuts force-pushed the hide_job_related_checks_when_inactive branch from 42bea90 to f504570 Compare August 2, 2023 09:24
@deadlycoconuts deadlycoconuts added the type: bug Something isn't working label Aug 2, 2023
@deadlycoconuts deadlycoconuts changed the title bugfix: Prevent calls to ensembling job service/controllers if batch ensembling is deactivated fix: Prevent calls to ensembling job service/controllers if batch ensembling is deactivated Aug 2, 2023
@deadlycoconuts deadlycoconuts marked this pull request as ready for review August 2, 2023 09:30
@deadlycoconuts
Copy link
Contributor Author

Thanks for the quick review! Merging this now! 😅

@deadlycoconuts deadlycoconuts merged commit 9262b6d into caraml-dev:main Aug 4, 2023
@deadlycoconuts deadlycoconuts deleted the hide_job_related_checks_when_inactive branch September 7, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants