Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nop Ensembler Config #192

Merged
merged 7 commits into from
Apr 21, 2022
+474 −122
Merged

Nop Ensembler Config #192

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5584da1
UI changes for nop ensembler config
Apr 17, 2022
549e1aa
Make handling of router / version status consistent
Apr 17, 2022
ce67a71
SDK changes for default route
Apr 19, 2022
905db5f
Correct the default route id in unit tests
Apr 19, 2022
f85af1e
Add tests for the nop ensembler config
Apr 20, 2022
f8b4439
Update sample code and doc
Apr 20, 2022
de2cd27
Add PR comments
Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct the default route id in unit tests
Krithika Sundararajan committed Apr 19, 2022

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 933B01F40B5CA946
Expired
Learn about vigilant mode
commit 905db5fdabad2e16e0d7e07aa3467281af912cf4
6 changes: 3 additions & 3 deletions sdk/tests/conftest.py
View file
Original file line number Diff line number Diff line change
@@ -454,8 +454,8 @@ def generic_router_version(
error="NONE",
image="test.io/just-a-test/turing-router:0.0.0-build.0",
routes=[generic_route for _ in range(2)],
default_route="http://models.internal/default",
default_route_id="control",
default_route=generic_route.endpoint,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were originally using a default route id that wasn't a part of the routes themselves. Now, the _verify_default_route_exists method added to sdk/turing/router/config/router_config.py will prevent that, so the route must be valid.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks a lot for adding this so more upfront checks are performed before sending any requests to the API!

default_route_id=generic_route.id,
rules=[generic_traffic_rule for _ in range(2)],
experiment_engine=experiment_config,
resource_request=generic_resource_request,
@@ -485,7 +485,7 @@ def generic_router_config():
)
],
rules=None,
default_route_id="test",
default_route_id="model-a",
experiment_engine=ExperimentConfig(
type="test-exp",
config={
2 changes: 1 addition & 1 deletion sdk/tests/testdata/api_responses/create_router_0000.json
View file
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@
"timeout": "100ms"
}
],
"default_route_id": "test",
"default_route_id": "model-a",
"experiment_engine": {
"type": "test-exp",
"config": {