Add UI/SDK support to pyfunc ensemblers #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
from
8487f9b
to
c4f7c9c
Compare
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
from
c4f7c9c
to
3634821
Compare
deadlycoconuts
changed the title
deadlycoconuts
changed the title
deadlycoconuts
changed the title
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
2 times, most recently
from
5236ab4
to
de0b0ab
Compare
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
from
de0b0ab
to
6ed052a
Compare
deadlycoconuts
commented
Mar 7, 2022
deadlycoconuts
commented
Mar 7, 2022
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
from
6ed052a
to
ff1d3b3
Compare
leonlnj
reviewed
Mar 9, 2022
leonlnj
reviewed
Mar 9, 2022
ui/src/router/components/form/components/pyfunc_config/PyFuncDeploymentPanel.js
Outdated
Show resolved
Hide resolved
leonlnj
reviewed
Mar 9, 2022
ui/src/router/components/form/components/pyfunc_config/PyFuncDeploymentPanel.js
Outdated
Show resolved
Hide resolved
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
from
15f3577
to
07b73e9
Compare
deadlycoconuts
commented
Mar 10, 2022
| ]; | ||
|
|
||
| if (!!dockerConfig) { | ||
| items.push({ |
There was a problem hiding this comment.
This ensures that the router details screen is minimally able to display a Pyfunc ensembler's name and ID (but not the dockerConfig related stuff) should the image building job fail during router deployment.
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
from
d5e455b
to
45d7639
Compare
|
thanks, lgtm! |
leonlnj
approved these changes
Mar 10, 2022
krithika369
reviewed
Mar 10, 2022
krithika369
reviewed
Mar 10, 2022
krithika369
reviewed
Mar 10, 2022
krithika369
approved these changes
Mar 11, 2022
ui/src/router/components/form/components/ensembler_config/typeOptions.js
Outdated
Show resolved
Hide resolved
deadlycoconuts
force-pushed
the
make_ui_support_pyfunc_ensembler
branch
from
217b39d
to
ec080a3
Compare
|
Thanks a lot everyone for the detailed comments, gonna merge this! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In PR #164 and PR #165, a real-time ensembler engine was introduced to process live ensembling requests, using an ensembler that is predefined in the
mlflowpyfunc flavour. In PR #170, a process was introduced in Turing API to automatically orchestrate the image building process of a user specified pyfunc ensembler (identified by its givenproject_idandensembler_id). Turing API then runs containers based on that generated image as an ensembler service as part of a Turing Router deployment.This PR introduces user interface changes in order to incorporate the minor tweaks associated with a Turing Router deployment with the inclusion of pyfunc ensemblers.
Minor additions/fixes were also made to Turing SDK to incorporate the
pyfunc_configobject created from PRs #164, #165 and #170.Not to be merged before PR #170.
Features
Creation of a panel in the router creation/editing page to select a pyfunc ensembler to deploy from a list of created ensemblers stored in Turing:
Creation of a panel on the router details page showing details of the pyfunc ensembler deployed, with the Ensembler ID and Ensembler Name shown:
Changing pyfunc ensemblers in an existing Turing Router will be reflected as expected for all Turing Router configuration on the diff page:
Main Modifications
ui/src/components/form/service_account_combo_box/ServiceAccountComboBox.js- Renaming ofServiceAccoutComboBox.jsto the more correctly spelledServiceAccountComboBox.jsui/src/router/components/configuration/components/EnsemblerConfigSection.js- Addition of a panel to display pyfunc ensembler configurationui/src/router/components/configuration/components/pyfunc_config_section/*- Addition of a panel to display pyfunc ensembler configurationui/src/router/components/form/components/ensembler_config/typeOptions.js- Addition of pyfunc ensemblers to the list of available ensembler optionsui/src/router/components/form/components/pyfunc_config/*- Addition of a new form to fill for pyfunc ensemblersui/src/router/components/form/validation/schema.js- Update to schema validation for pyfunc ensemblersui/src/services/ensembler/PyFuncEnsembler.js- Addition of new pyfunc ensembler serviceMinor Changes to Turing SDK
sdk/turing/generated/*- Changes to OpenAPI auto-generated SDK classes after changes to OpenAPI specs in PR Automate ensembler image building with Turing API #170sdk/turing/router/config/router_ensembler_config.py- Addition of a new SDK class to supportpyfunc_configsdk/turing/router/router.py- Minor changes to functions after changes to OpenAPI specs in PR Automate ensembler image building with Turing API #170sdk/turing/session.py- Minor changes to functions after changes to OpenAPI specs in PR Automate ensembler image building with Turing API #170