Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch-predictor): remove CPU limits from SparkApplication resource #615

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mbruner
Copy link
Member

@mbruner mbruner commented Nov 5, 2024

Description

Similar to kserve models, this PR removes CPU limits for batch prediction jobs. If limits are set, executors will experience significant throttling because batch jobs tend to consume all available CPU by its nature.

Modifications

  • SparkApplication resource no longer has coreLimit set in driver and executor specs. This field is optional according to the specs and it should be safe to simply remove it.

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

Remove CPU Limits for batch prediction jobs

@mbruner mbruner added the enhancement New feature or request label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.67%. Comparing base (0877a4f) to head (be46b79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   60.68%   59.67%   -1.01%     
==========================================
  Files         277      277              
  Lines       22245    25999    +3754     
==========================================
+ Hits        13500    15516    +2016     
- Misses       7877     9616    +1739     
+ Partials      868      867       -1     
Flag Coverage Δ
api-test 57.86% <ø> (-0.80%) ⬇️
sdk-test-3.10 75.51% <ø> (ø)
sdk-test-3.8 75.49% <ø> (ø)
sdk-test-3.9 75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbruner mbruner self-assigned this Nov 5, 2024
@mbruner mbruner changed the title feat(batch): remove CPU limits from SparkApplication resource feat(batch-predictor): remove CPU limits from SparkApplication resource Nov 5, 2024
@mbruner mbruner marked this pull request as ready for review November 5, 2024 08:17
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks for the changes!

@mbruner mbruner merged commit 7f7d42c into main Nov 5, 2024
23 of 25 checks passed
@mbruner mbruner deleted the remove-cpu-limits-for-batch-jobs branch November 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants