Skip to content

Commit

Permalink
Fix incorrect function name called in unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
deadlycoconuts committed Nov 7, 2024
1 parent 163f60b commit 6acd1b4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions python/sdk/test/utils_unit_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from merlin.util import guess_mlp_ui_url, valid_name_check, get_bucket_name, get_artifact_path
from merlin.util import guess_mlp_ui_url, valid_name_check, get_blob_storage_scheme, get_bucket_name, get_artifact_path
import pytest


Expand All @@ -37,10 +37,10 @@ def test_name_check():
@pytest.mark.unit
def test_get_blob_storage_scheme():
gcs_artifact_uri = 'gs://some-bucket/mlflow/81/ddd'
assert test_get_blob_storage_scheme(gcs_artifact_uri) == 'gs'
assert get_blob_storage_scheme(gcs_artifact_uri) == 'gs'

s3_artifact_uri = 's3://some-bucket/mlflow/81/ddd'
assert test_get_blob_storage_scheme(s3_artifact_uri) == 's3'
assert get_blob_storage_scheme(s3_artifact_uri) == 's3'


@pytest.mark.unit
Expand All @@ -62,7 +62,7 @@ def test_get_artifact_path():
("http://console.mydomain.com/merlin/api", "http://console.mydomain.com/merlin"),
("https://console.mydomain.com/merlin/api", "https://console.mydomain.com/merlin"),
("console.mydomain.com/merlin/api", "http://console.mydomain.com/merlin"),
])

@pytest.mark.unit
def test_guess_mlp_ui_url(mlp_api_url, expected):
assert guess_mlp_ui_url(mlp_api_url) == expected

0 comments on commit 6acd1b4

Please sign in to comment.