Skip to content

Conversation

@Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Jul 3, 2021

The vendored capstone is updated to include capstone-engine/capstone#1682.

@Amanieu
Copy link
Contributor Author

Amanieu commented Jul 6, 2021

CI failure seems to be unrelated, the same error happens on master.

@tmfink
Copy link
Member

tmfink commented Jul 11, 2021

Thanks for the PR, this looks really great!

My only request is that you add some unit tests, which will increase confidence (especially when we make subsequent upgrades to the bundled capstone). I suggest convert several of the instructions from capstone-sys/capstone/tests/test_riscv.c.

As an example, take a look at capstone-rs/src/test.rs tests test_arch_mips()/test_arch_mips_detail().

@Amanieu
Copy link
Contributor Author

Amanieu commented Jul 12, 2021

@tmfink tmfink merged commit 3f40cd3 into capstone-rust:master Jul 12, 2021
@tmfink
Copy link
Member

tmfink commented Jul 12, 2021

@Amanieu
Copy link
Contributor Author

Amanieu commented Jul 12, 2021

Could you publish a new version with this change?

@Amanieu
Copy link
Contributor Author

Amanieu commented Jul 13, 2021

Ping for publishing a new release.

@tmfink
Copy link
Member

tmfink commented Jul 14, 2021

I published version 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants