Fix comparison using narrow types in loop condition #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Spotted by GitHub CodeQL vulnerability scanner * Related to: CWE-190, CWE-197 and CWE-835.
aquynh
approved these changes
May 17, 2024
Rot127
approved these changes
May 17, 2024
Rot127
added a commit
to Rot127/capstone
that referenced
this pull request
May 17, 2024
Rot127
added a commit
to Rot127/capstone
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
The type of the looping variable is smaller than the one used to end the loop. So it is possible to cause an infinite loop because of the wraparound.
Test plan
Probably
nextis affected too. But i'm lazy to test other branches right now.Closing issues
There are no issues refering to this issue