Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang tidy #2347

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix clang tidy #2347

merged 2 commits into from
May 1, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Apr 30, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes:

  • A build error in cstest when build with cmake.
  • clang-tidy script was broken because origin/next is not pulled within the Github environment.

Test plan

All green

Closing issues

...

@Rot127 Rot127 force-pushed the fix-clang-tidy branch 2 times, most recently from 61d9198 to 9e0e1f2 Compare April 30, 2024 06:47
@github-actions github-actions bot added the CS-core-files auto-sync label Apr 30, 2024
@Rot127 Rot127 force-pushed the fix-clang-tidy branch 2 times, most recently from 99ef3f2 to 52afab1 Compare April 30, 2024 07:06
@Rot127 Rot127 marked this pull request as draft April 30, 2024 07:06
@Rot127 Rot127 force-pushed the fix-clang-tidy branch 11 times, most recently from cf99f2e to 5fbe7d6 Compare April 30, 2024 08:26
@github-actions github-actions bot removed the CS-core-files auto-sync label Apr 30, 2024
@Rot127 Rot127 marked this pull request as ready for review April 30, 2024 08:49
@kabeor kabeor merged commit 8f9a337 into capstone-engine:next May 1, 2024
14 checks passed
@Rot127 Rot127 deleted the fix-clang-tidy branch May 1, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants