-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v6] Move meta-programming macros for ARM64/AArch64 to capstone.h #2201
Conversation
Add some tests plz:) |
I could add a CI test to run the pre-processor step on some dummy file which uses those macros. Though it feels a little over-engineered to me. Do you have a better idea? Generally though we use these macros in Rizin. And we build Rizin with v4, v5 and now v6 in our CI. So they are tested there and I'll detect errors. |
Or a dummy program which uses them. And we compile it for |
Ah I just thought we can copy test_aarch64.c and rename all aarch64 to arm64, which is simple and effective. How do you think? By the way, I found test_aarch64 binary is merged into the repository. |
|
Thanks,the binary should be completely purged from the whole commits history. Or the repository size will increase with the accumulation of new commits. |
eab1a7b
to
101e72e
Compare
101e72e
to
c85f2b6
Compare
@kabeor Please check again. |
Cool, merged. |
Move the meta-programming macros for
ARM64
->AArch64
name change tocapstone.h
so it is consistent with #2199 and #2200