[ARM] Remove LDM leftover code #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Added accidentally two more unrelated fixes to this branch. Let me know if you'd like them in a separated PR. |
Member
|
@Rot127 Hi，needn't to separate this time, but can you describe more about these two commits in this PR's detail widget? |
The (incorrect) Shift amount was set to the incorrect operand (an operand which doesn't exists).
The immediate was not processed through ARM_AM_getAM3Offset before adding it to detail.
Rot127
force-pushed
the
arm-ldm-leftovers
branch
from
8eb4989 to
9590978
Compare
Collaborator
Author
|
@kabeor I extended the commit description. Its better for future people as well. |
Member
|
ok thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some forgotten leftover code which is already handled with patches or in ARMMapping.c