Skip to content

Conversation

@meme
Copy link
Contributor

@meme meme commented Oct 24, 2020

For projects that embed Capstone and have their own installer, prevent Capstone from installing as well for the ALL target.

@aquynh aquynh merged commit d71c95b into capstone-engine:master Oct 27, 2020
@aquynh
Copy link
Collaborator

aquynh commented Oct 27, 2020

merged, thanks.

can you send pull req for the "next" branch, too?

aquynh pushed a commit that referenced this pull request Oct 27, 2020
@meme
Copy link
Contributor Author

meme commented Oct 28, 2020

Done: #1700

@meme
Copy link
Contributor Author

meme commented Oct 28, 2020

Could this PR also be labelled with hacktoberfest-accepted? And perhaps you may want to mark the repository with a tag for hacktoberfest as the event is now opt-in (more details here).

@aquynh
Copy link
Collaborator

aquynh commented Oct 28, 2020

yes, exactly what do i need to do?

@meme
Copy link
Contributor Author

meme commented Oct 28, 2020

Just create the label hacktoberfest-accepted on the issue tracker (here) and then label this issue with it. Thanks!

@aquynh
Copy link
Collaborator

aquynh commented Oct 29, 2020

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants