-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix for make.sh for android #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
make.sh
Outdated
| } | ||
|
|
||
| CROSS="$TOOLCHAIN/bin/$CROSS" CFLAGS="--sysroot=$PLATFORM" LDFLAGS="--sysroot=$PLATFORM" ${MAKE} $* | ||
| #CC="${STANDALONE}/bin/clang" CFLAGS="--sysroot=${STANDALONE}/sysroot" ${MAKE} $* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this commented out line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
|
merged, thanks! |
| ifeq ($(CROSS),) | ||
| RANLIB ?= ranlib | ||
| else ifeq ($(ANDROID), 1) | ||
| CC = $(CROSS)/../../bin/clang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a standard place for clang??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so. $(CROSS)/../../bin/clang means ${STANDALONE}/bin/clang, in that dir, you can find all versions of clang, as the following:
root@xxx:~/workspace/capstone# ls android-ndk-arm64-android-21/bin/*clang*
android-ndk-arm64-android-21/bin/aarch64-linux-android-clang
android-ndk-arm64-android-21/bin/aarch64-linux-android-clang++
android-ndk-arm64-android-21/bin/aarch64-linux-android21-clang
android-ndk-arm64-android-21/bin/aarch64-linux-android21-clang++
...
...
* fix for make.sh for android * remove commented line
* fix for make.sh for android * remove commented line
|
/root/capstone/android-ndk-arm64-android-21/aarch64-linux-android/bingcc: not found |
NDK=/path/to/the/unzipped/ndk/dir ./make.sh cross-android arm64 [clean]to test it. The build process is well but there is a problem formake test, the failure is because of the lack ofbingcc: