#1246 - Fix Java bindings to use pointers instead of longs #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ongs Previously, a long was used instead of a pointer in the JNA binding library. This would work until the allocated pointers exceeded 32-bits. On modern JVMs, allocations may produce pointers in excess of 32-bits which would result in invalid memory access errors. This also updates the binding version to 5.0.
Collaborator
|
is this change still backward compatible (with older Java)? |
Contributor
Author
|
I tried it with JVM 8, JVM 9, and JVM 11, and they all worked. I did not try anything earlier than 8 which is the latest JVM that worked previously. |
Collaborator
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
Jul 11, 2019
Previously, a long was used instead of a pointer in the JNA binding library. This would work until the allocated pointers exceeded 32-bits. On modern JVMs, allocations may produce pointers in excess of 32-bits which would result in invalid memory access errors. This also updates the binding version to 5.0.
aquynh
pushed a commit
that referenced
this pull request
Jul 11, 2019
Previously, a long was used instead of a pointer in the JNA binding library. This would work until the allocated pointers exceeded 32-bits. On modern JVMs, allocations may produce pointers in excess of 32-bits which would result in invalid memory access errors. This also updates the binding version to 5.0.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a long was used instead of a pointer in the JNA binding library.
This would work until the allocated pointers exceeded 32-bits. On modern JVMs,
allocations may produce pointers in excess of 32-bits which would result in
invalid memory access errors.
This also updates the binding version to 5.0.