Print EFLAGS and FPU_FLAGS correctly in test_x86 #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the eflags and fpu_flags are union the instruction group needs to be checked for FPU to see if the flag is an FPU flag. cstool_x86 was already doing this but test_x86 was not. The result was the fadd instruction from the x86 16bit test was showing in the test_x86 output as having eflags. Since fadd is an fpu instruction the FPU_FLAGS should be shown instead.
All of the other test_<arch>.c functions print a single newline after the dissassembly. x86 had two newlines. This makes test_x86 consistent with all the other test output.
knightsc
added a commit
to knightsc/gapstone
that referenced
this pull request
Feb 4, 2019
See capstone-engine/capstone#1365 The capstone output is incorrect. Disabling genspec for now so the test suite uses the checked in version for now
Collaborator
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
Feb 5, 2019
* Print EFLAGS and FPU_FLAGS correctly in test_x86 Since the eflags and fpu_flags are union the instruction group needs to be checked for FPU to see if the flag is an FPU flag. cstool_x86 was already doing this but test_x86 was not. The result was the fadd instruction from the x86 16bit test was showing in the test_x86 output as having eflags. Since fadd is an fpu instruction the FPU_FLAGS should be shown instead. * Remove extra newline in instruction output All of the other test_<arch>.c functions print a single newline after the dissassembly. x86 had two newlines. This makes test_x86 consistent with all the other test output.
aquynh
pushed a commit
that referenced
this pull request
Feb 5, 2019
* Print EFLAGS and FPU_FLAGS correctly in test_x86 Since the eflags and fpu_flags are union the instruction group needs to be checked for FPU to see if the flag is an FPU flag. cstool_x86 was already doing this but test_x86 was not. The result was the fadd instruction from the x86 16bit test was showing in the test_x86 output as having eflags. Since fadd is an fpu instruction the FPU_FLAGS should be shown instead. * Remove extra newline in instruction output All of the other test_<arch>.c functions print a single newline after the dissassembly. x86 had two newlines. This makes test_x86 consistent with all the other test output.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the eflags and fpu_flags are union the instruction group needs
to be checked for FPU to see if the flag is an FPU flag. cstool_x86
was already doing this but test_x86 was not. The result was the fadd
instruction from the x86 16bit test was showing in the test_x86
output as having eflags. Since fadd is an fpu instruction the FPU_FLAGS
should be shown instead.