Fix arm thb instruction shift value #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a more detailed description, see issue capstone-engine#1317. Release 4.0.0 introduced a new field for ARM operands: `operand.mem.lshift`. This field was supposed to be a bug fix for capstone-engine#246. The capstone-engine#246 issue has been fixed in the meantime and the proper shift value was stored in `operand.shift.value`. The 4.0.0 changes created a regression in which `operand.shift.value` was not set for a `tbh [r0, r1, lsl capstone-engine#1]` instruction on ARM and the value was set in a `operand.mem.lshift` field instead. As the regression broke some of users codebase (e.g. in [manticore](trailofbits/manticore#1312) project), we fix it by setting `operand.shift.value` back again. As a result, the shift value is set in two fields: `operand.shift.value` and `operand.mem.lshift`. As the `operand.shift` also stores a `.type` field, we might want to deprecate `operand.mem.lshift` in the future.
This was referenced Jan 1, 2019
Collaborator
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a more detailed description, see issue #1317.
Release 4.0.0 introduced a new field for ARM operands:
operand.mem.lshift. This field was supposed to be a bug fix for #246. The #246 issue has been fixed in the meantime and the proper shift value was stored inoperand.shift.value.The 4.0.0 changes created a regression in which
operand.shift.valuewas not set for atbh [r0, r1, lsl #1]instruction on ARM and the value was set in aoperand.mem.lshiftfield instead.As the regression broke some of users codebase (e.g. in manticore project), we fix it by setting
operand.shift.valueback again.As a result, the shift value is set in two fields:
operand.shift.valueandoperand.mem.lshift.As the
operand.shiftalso stores a.typefield, we might want to deprecateoperand.mem.lshiftin the future.