Skip to content

fix: [#2057] Support Unicode characters in selectors per CSS spec #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
capricorn86 merged 3 commits into from
Feb 10, 2026
Merged

fix: [#2057] Support Unicode characters in selectors per CSS spec #2062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1aaa886
fix: [#2057] Support Unicode characters in selectors per CSS spec
Feb 10, 2026
a845c2a
chore: [#2057] Adds unit tests
capricorn86 Feb 10, 2026
8ae29be
chore: [#2057] Adds unit tests
capricorn86 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/happy-dom/src/query-selector/SelectorParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import type DocumentFragment from '../nodes/document-fragment/DocumentFragment.j
* Group 17: Combinator.
*/
const SELECTOR_REGEXP =
/(\*)|([a-zA-Z0-9-]+)|#((?:[a-zA-Z0-9-_«»]|\\.)+)|\.((?:[a-zA-Z0-9-_«»]|\\.)+)|\[([a-zA-Z0-9-_\\:]+)\]|\[([a-zA-Z0-9-_\\:]+)\s*([~|^$*]{0,1})\s*=\s*["']{1}([^"']*)["']{1}\s*(s|i){0,1}\]|\[([a-zA-Z0-9-_]+)\s*([~|^$*]{0,1})\s*=\s*([^\]]*)\]|:([a-zA-Z-]+)\s*\(((?:[^()]|\[[^\]]*\]|\([^()]*\))*)\){0,1}|:([a-zA-Z-]+)|::([a-zA-Z-]+)|([\s,+>~]*)/gm;
/(\*)|([a-zA-Z0-9\u00A0-\uFFFF-]+)|#((?:[a-zA-Z0-9\u00A0-\uFFFF_-]|\\.)+)|\.((?:[a-zA-Z0-9\u00A0-\uFFFF_-]|\\.)+)|\[([a-zA-Z0-9-_\\:]+)\]|\[([a-zA-Z0-9-_\\:]+)\s*([~|^$*]{0,1})\s*=\s*["']{1}([^"']*)["']{1}\s*(s|i){0,1}\]|\[([a-zA-Z0-9-_]+)\s*([~|^$*]{0,1})\s*=\s*([^\]]*)\]|:([a-zA-Z-]+)\s*\(((?:[^()]|\[[^\]]*\]|\([^()]*\))*)\){0,1}|:([a-zA-Z-]+)|::([a-zA-Z-]+)|([\s,+>~]*)/gm;

/**
* Escaped Character RegExp.
Expand Down Expand Up @@ -60,7 +60,8 @@ const SPACE_REGEXP = / /g;
* Group 2: Class (e.g. ".classA.classB")
* Group 3: ID (e.g. "#id")
*/
const SIMPLE_SELECTOR_REGEXP = /(^[a-zA-Z0-9-]+$)|(^\.[a-zA-Z0-9-_.]+$)|(^#[a-zA-Z0-9-_]+$)/;
const SIMPLE_SELECTOR_REGEXP =
/(^[a-zA-Z0-9\u00A0-\uFFFF-]+$)|(^\.[a-zA-Z0-9\u00A0-\uFFFF_.]+$)|(^#[a-zA-Z0-9\u00A0-\uFFFF_-]+$)/;

/**
* Utility for parsing a selection string.
Expand Down
12 changes: 12 additions & 0 deletions packages/happy-dom/test/nodes/parent-node/ParentNodeUtility.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,18 @@ describe('ParentNodeUtility', () => {
expect(elementByClassName[1]).toBe(element2);
expect(elementByClassName[2]).toBe(element3);
});

it('Returns element matching unicode class name', () => {
const div = document.createElement('div');
const unicodeClassName = 'class-😀';
const element = document.createElement('span');
element.className = unicodeClassName;
div.appendChild(element);
document.body.appendChild(div);

expect(div.getElementsByClassName(unicodeClassName)).toBe(element);
expect(document.getElementsByClassName(unicodeClassName)).toBe(element);
});
});

describe('getElementsByTagName()', () => {
Expand Down
10 changes: 10 additions & 0 deletions packages/happy-dom/test/query-selector/QuerySelector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,6 +1863,16 @@ describe('QuerySelector', () => {
it('Return element for pseudo selector ":root"', () => {
expect(document.querySelectorAll(':root')[0]).toBe(document.documentElement);
});

it('Returns element matching unicode class name', () => {
const div = document.createElement('div');
const unicodeClassName = 'class-😀';
const element = document.createElement('span');
element.className = unicodeClassName;
div.appendChild(element);

expect(div.querySelector(`.${unicodeClassName}`)).toBe(element);
});
});

describe('matches()', () => {
Expand Down