Skip to content

fix: [#2034] QuerySelector fails to match attribute values containing quotes #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JalilArfaoui wants to merge 1 commit into from
Closed

fix: [#2034] QuerySelector fails to match attribute values containing quotes #2036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/happy-dom/src/query-selector/SelectorParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import DocumentFragment from '../nodes/document-fragment/DocumentFragment.js';
* Group 17: Combinator.
*/
const SELECTOR_REGEXP =
/(\*)|([a-zA-Z0-9-]+)|#((?:[a-zA-Z0-9-_«»]|\\.)+)|\.((?:[a-zA-Z0-9-_«»]|\\.)+)|\[([a-zA-Z0-9-_\\:]+)\]|\[([a-zA-Z0-9-_\\:]+)\s*([~|^$*]{0,1})\s*=\s*["']{1}([^"']*)["']{1}\s*(s|i){0,1}\]|\[([a-zA-Z0-9-_]+)\s*([~|^$*]{0,1})\s*=\s*([^\]]*)\]|:([a-zA-Z-]+)\s*\(((?:[^()]|\[[^\]]*\]|\([^()]*\))*)\){0,1}|:([a-zA-Z-]+)|::([a-zA-Z-]+)|([\s,+>~]*)/gm;
/(\*)|([a-zA-Z0-9-]+)|#((?:[a-zA-Z0-9-_«»]|\\.)+)|\.((?:[a-zA-Z0-9-_«»]|\\.)+)|\[([a-zA-Z0-9-_\\:]+)\]|\[([a-zA-Z0-9-_\\:]+)\s*([~|^$*]{0,1})\s*=\s*["']((?<=")[^"]*(?=")|(?<=')[^']*(?='))["']\s*(s|i){0,1}\]|\[([a-zA-Z0-9-_]+)\s*([~|^$*]{0,1})\s*=\s*([^\]]*)\]|:([a-zA-Z-]+)\s*\(((?:[^()]|\[[^\]]*\]|\([^()]*\))*)\){0,1}|:([a-zA-Z-]+)|::([a-zA-Z-]+)|([\s,+>~]*)/gm;

/**
* Escaped Character RegExp.
Expand Down
18 changes: 18 additions & 0 deletions packages/happy-dom/test/query-selector/QuerySelector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,24 @@ describe('QuerySelector', () => {
expect(elements[1] === container.children[0].children[1].children[1]).toBe(true);
});

it('Returns elements with attribute values containing apostrophes using double quotes as delimiter.', () => {
const container = document.createElement('div');
container.innerHTML = `<div data-value="it's a test">Content</div>`;

const elements = container.querySelectorAll('[data-value="it\'s a test"]');
expect(elements.length).toBe(1);
expect(elements[0] === container.children[0]).toBe(true);
});

it('Returns elements with attribute values containing double quotes using apostrophes as delimiter.', () => {
const container = document.createElement('div');
container.innerHTML = `<div data-value='say "hello"'>Content</div>`;

const elements = container.querySelectorAll('[data-value=\'say "hello"\']');
expect(elements.length).toBe(1);
expect(elements[0] === container.children[0]).toBe(true);
});

it('Returns all elements with tag name and matching attributes using "span[_attr1]".', () => {
const container = document.createElement('div');
container.innerHTML = QuerySelectorHTML.replace(/ attr1/gm, '_attr1');
Expand Down