fix: [#1526] Handles scenario where a symbol property doesn't exist o…

…n HTMLSelectElement (#1527)
capricorn86 · Sep 1, 2024 · afc3692 · afc3692
1 parent 20b520a
commit afc3692
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/packages/happy-dom/src/nodes/html-select-element/HTMLSelectElement.ts b/packages/happy-dom/src/nodes/html-select-element/HTMLSelectElement.ts
@@ -118,6 +118,10 @@ export default class HTMLSelectElement extends HTMLElement {
 					return true;
 				}
 
+				if (typeof property === 'symbol') {
+					return false;
+				}
+
 				const index = Number(property);
 
 				if (!isNaN(index)) {

diff --git a/packages/happy-dom/test/nodes/html-select-element/HTMLSelectElement.test.ts b/packages/happy-dom/test/nodes/html-select-element/HTMLSelectElement.test.ts
@@ -239,6 +239,23 @@ describe('HTMLSelectElement', () => {
 		});
 	});
 
+	describe('get symbol()', () => {
+		it('returns existing symbol properties', () => {
+			const symbol = Symbol('test');
+			element[symbol] = 'test';
+			expect(element[symbol]).toBe('test');
+		});
+
+		it('ignores missing symbol properties', () => {
+			const symbol = Symbol('other-test');
+
+			expect(element[symbol]).toBe(undefined);
+
+			// https://github.com/capricorn86/happy-dom/issues/1526
+			expect(symbol in element).toBe(false);
+		});
+	});
+
 	describe(`set selectedIndex()`, () => {
 		it('Allows -1', () => {
 			element.selectedIndex = -1;