Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please upgrade to quickcheck 1 #274

Closed
dkg opened this issue Jun 28, 2022 · 3 comments
Closed

please upgrade to quickcheck 1 #274

dkg opened this issue Jun 28, 2022 · 3 comments

Comments

@dkg
Copy link
Contributor

dkg commented Jun 28, 2022

the quickcheck crate is at version 1.0.3 now. it would be great if the capnp crate migrated from its dependency on quickcheck 0.9 to quickcheck 1, as that looks to be a more stable API.

@dkg
Copy link
Contributor Author

dkg commented Jun 28, 2022

The main issue is that quickcheck 1 has Gen as a struct, whereas 0.9 has it as a trait, and capnp uses it as a trait. See for example BurntSushi/quickcheck#277. Sorry to not have better advice on how to make this transition.

@dwrensha
Copy link
Member

I expect that upgrading quickcheck should be straightforward. When we do that we should probably bump the version number of the capnp crates (from 0.14 to 0.15). I hesitate to do that immediately -- it'd be nice if we could batch some of other non-backward compatible changes too, to minimize version churn. One that I have in mind is cleaning up the traits with Generic Associated Types, but unfortunately support for those seems to have stalled somewhat rust-lang/rust#96709.

@dkg
Copy link
Contributor Author

dkg commented Jun 28, 2022

I'm working on a fix that i think won't actually change the capnp API at all (with some explanatory help from good folks over at sequoia). I'll submit that shortly. if you think that it does warrant a semver-incompatible bump, i'd be interested in understanding why, i'm still trying to get my head around these details.

dkg added a commit to dkg/capnproto-rust that referenced this issue Jun 28, 2022
It's not clear to me whether this has an impact on the public API of
capnp.  If it does, it might warrant a semver bump.

Closes: capnproto#274
dkg added a commit to dkg/capnproto-rust that referenced this issue Jun 28, 2022
dwrensha pushed a commit that referenced this issue Oct 29, 2022
ErikMcClure pushed a commit to Fundament-Software/capstone-rs that referenced this issue Mar 25, 2024
It's not clear to me whether this has an impact on the public API of
capnp.  If it does, it might warrant a semver bump.

Closes: capnproto#274
ErikMcClure pushed a commit to Fundament-Software/capstone-rs that referenced this issue Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants