-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
please upgrade to quickcheck 1 #274
Comments
The main issue is that quickcheck 1 has Gen as a struct, whereas 0.9 has it as a trait, and capnp uses it as a trait. See for example BurntSushi/quickcheck#277. Sorry to not have better advice on how to make this transition. |
I expect that upgrading quickcheck should be straightforward. When we do that we should probably bump the version number of the capnp crates (from 0.14 to 0.15). I hesitate to do that immediately -- it'd be nice if we could batch some of other non-backward compatible changes too, to minimize version churn. One that I have in mind is cleaning up the traits with Generic Associated Types, but unfortunately support for those seems to have stalled somewhat rust-lang/rust#96709. |
I'm working on a fix that i think won't actually change the capnp API at all (with some explanatory help from good folks over at sequoia). I'll submit that shortly. if you think that it does warrant a semver-incompatible bump, i'd be interested in understanding why, i'm still trying to get my head around these details. |
It's not clear to me whether this has an impact on the public API of capnp. If it does, it might warrant a semver bump. Closes: capnproto#274
It's not clear to me whether this has an impact on the public API of capnp. If it does, it might warrant a semver bump. Closes: capnproto#274
the quickcheck crate is at version 1.0.3 now. it would be great if the
capnp
crate migrated from its dependency on quickcheck 0.9 to quickcheck 1, as that looks to be a more stable API.The text was updated successfully, but these errors were encountered: