Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change parameter to be more flexible #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change parameter to be more flexible #114

wants to merge 1 commit into from

Conversation

JTMCaplin
Copy link
Contributor

No description provided.

@briandipalma
Copy link
Contributor

Could you change the commit message to highlight the breaking change by using the convetional-commit standard? https://github.com/caplin/caplin-dev-tools#releasing-packages

@JTMCaplin JTMCaplin force-pushed the FXST-3547-get-build-numbers-working-correctly branch from 05466c5 to cde2622 Compare June 11, 2019 15:56
@JTMCaplin
feat: Add toggle whether artifact includes branch
45696c2 
BREAKING CHANGE: master branch name option has changed to
dontAppendBranchName. When set to true branch name won't be added to the
artifact name.

closes FXST-3547
@JTMCaplin JTMCaplin force-pushed the FXST-3547-get-build-numbers-working-correctly branch from cde2622 to 45696c2 Compare June 11, 2019 15:57
@briandipalma
Copy link
Contributor

@JTMCaplin do we still want this merged?

@JTMCaplin
Copy link
Contributor Author

@JTMCaplin do we still want this merged?

@JTMCaplin JTMCaplin closed this Jun 26, 2019
@JTMCaplin JTMCaplin reopened this Jun 26, 2019
@JTMCaplin
Copy link
Contributor Author

I hope that didn't fuck things. Yes we still want this merged.

@briandipalma
Copy link
Contributor

@JTMCaplin is there a JIRA that describes what we are aiming for here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amunozcap amunozcap amunozcap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JTMCaplin @briandipalma @amunozcap