all mismatches #64
Merged
all mismatches #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 12, 2024
* [WIP] adding all_mismatch * adding tests for mismatches * tweaking docstr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially relates back to #43
Expands on
sample_mismatchto provide a new function calledall_mismatch. This will provide all rows which mismatch back as a dataframe so users can export, query, or analyze if there are a lot of them. It keeps the join keys and all columns where a "match" was run.I left out the export part from the original request since from a df you can easily do that in the format you like.