Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fugue optional dependency #360

Merged
merged 3 commits into from
Dec 10, 2024
Merged

fugue optional dependency #360

merged 3 commits into from
Dec 10, 2024

Conversation

fdosani
Copy link
Member

@fdosani fdosani commented Dec 9, 2024

Ref: #359

  • Initial PR to move Fugue as being an optional dependency.
  • More explicit logging
  • General cleanup and skipping of tests when module not found.

@fdosani fdosani marked this pull request as ready for review December 9, 2024 19:32
ak-gupta
ak-gupta reviewed Dec 10, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
.github/workflows/test-package.yml Show resolved Hide resolved
@fdosani fdosani requested a review from ak-gupta December 10, 2024 15:45
@fdosani fdosani merged commit b84a1c9 into develop Dec 10, 2024
49 checks passed
@fdosani fdosani deleted the fugue-optional branch December 10, 2024 20:07
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ak-gupta ak-gupta ak-gupta approved these changes

@jdawang jdawang Awaiting requested review from jdawang jdawang is a code owner

@gladysteh99 gladysteh99 Awaiting requested review from gladysteh99 gladysteh99 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdosani @ak-gupta