Ruff #326
Merged
Ruff #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 11, 2024
* Ruff safe fixes * Ruff unsafe fixes * Manual fixes * Update workflow * Reexport from base * Fix boolean comparison * Simplify boolean expr * Simplify subset bool expr
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 12, 2024
* Ruff safe fixes * Ruff unsafe fixes * Manual fixes * Update workflow * Reexport from base * Fix boolean comparison * Simplify boolean expr * Simplify subset bool expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added ruff as our linter and formatter, made corresponding changes to code and added ruff to pre-commit and GH workflows. In this process, I have enabled the numpy rules which prepares datacompy to upgrade to numpy 2.0. Unfortunately, due to compatibility issues with pyspark.pandas and numpy 2.0, some further changes to the imports/guarding will be required to allow numpy 2.0 to be installed alongside datacompy