Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile inference in nitrogen::build #50

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Fix Dockerfile inference in nitrogen::build #50

merged 4 commits into from
Nov 4, 2022

Conversation

jvmncs
Copy link
Contributor

@jvmncs jvmncs commented Nov 4, 2022

Fixes the nitrogen::build command to look for the Dockerfile in the provided dockerfile_dir argument. Also adds a few slightly better log/error messages elsewhere

@jvmncs jvmncs requested a review from justin1121 November 4, 2022 16:49
justin1121
justin1121 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@justin1121 justin1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvmncs jvmncs merged commit fd1f0a3 into main Nov 4, 2022
@jvmncs jvmncs deleted the fix-ng-build branch November 4, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin1121 justin1121 justin1121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvmncs @justin1121