-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(badge): import UserNotifications
to support MacOS
#27
fix(badge): import UserNotifications
to support MacOS
#27
Conversation
iOS automatically imports UserNotifications, but Mac OS does not. This actually fixes the plugin to let it work in Mac OS builds. Signed-off-by: Evan Owen <[email protected]>
I'm having trouble getting the verification to run, getting some errors related to Java versions (have 1.8.0_361 installed). Maybe someone can help point me in the right direction of resolving it:
|
You need to use Java 11. Let’s the if the pipeline run is successful. |
@kainosnoema Please note that all plugins are already updated to Capacitor 5 for the next release. just FYI |
Doh of course, I just installed the one recommended on java.com.. haven't done that in awhile. Ok.
Got it, that's fine we'll be upgrading to Capacitor 5 soon. For now we have a workaround to get this building in our project so this change is low priority. Just wanted to suggest it in case we might be able to remove our workaround down the road. |
UserNotifications
to support MacOS
Description
We're maintaining a private fork of Capacitor with slight changes for Mac OS compatibility with WKWebView (works great, actually), and the Badge plugin works well with one small tweak: need to import
UserNotifications
explicitly since it's not imported by default by Mac OS (as it is in iOS). I realize you're not attempting to support Mac OS here but it's a small, harmless addition that would be great to get in—otherwise we'll have to maintain our own fork of this repo.Pull request checklist
npm run changeset
).