[MRG] add CLI for convert #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can refer to #288 to get model object from its ID, @STALLAAAA |
univerone
reviewed
Apr 19, 2021
modelci/cli/modelhub.py
Outdated
|
|
||
| @app.command('convert') | ||
| def convert( | ||
| id: str = typer.Option(..., '-i', '--id', help='ID of model.'), |
There was a problem hiding this comment.
It's better to add more argument, such as:
- the model format use want to convert this model into, you can the use
convertfunction - the saved path of the converted model
- whether to register the generated model into model hub
There was a problem hiding this comment.
I add 2 new arguments for savepath and register. I will add each specified convert after I make a revise to its function in the next PR.
dixing0908
force-pushed
the
dev
branch
3 times, most recently
from
72a4d7d
to
b2ce09e
Compare
:fix: add 2 arguments of convert cli
:fix: make 'generate_model_family' a public function
:fix:convert cli: provide args:
1. the saved path of the converted model
2. whether to register the generated model into model hub
HuaizhengZhang
approved these changes
Apr 21, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248
What has been done to verify that this works as intended?
This is a cli command for convert component.
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to documentation?
Before submitting this PR, please make sure you have:
python -m pytest tests/and confirmed all checks still pass.