[268]- Fix/Delete cascading attachments when deleting parent #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror handling for scan process
|
Talking with a colleague, we just noticed that this code may ignore two level cascading - e.g. Delete a Collection of Books that have attachments |
|
Additionally observed - if the transaction fails at the last part, the database part will rollback. But the file would be deleted from the S3, since the delete file is called at the after handler. |
KoblerS
reviewed
Oct 17, 2025
Co-authored-by: Simon Kobler <[email protected]>
Co-authored-by: Simon Kobler <[email protected]>
Co-authored-by: Simon Kobler <[email protected]>
Co-authored-by: Simon Kobler <[email protected]>
KoblerS
reviewed
Oct 17, 2025
Co-authored-by: Simon Kobler <[email protected]>
KoblerS
approved these changes
Oct 17, 2025
|
Tests for outboxing behaviour are missing then it can be merged. |
KoblerS
reviewed
Oct 20, 2025
eric-pSAP
approved these changes
Oct 20, 2025
Co-authored-by: Simon Kobler <[email protected]>
Co-authored-by: Simon Kobler <[email protected]>
Co-authored-by: Simon Kobler <[email protected]>
…ithub.com/cap-js/attachments into fix/delete-attachments-when-delete-parent
KoblerS
reviewed
Oct 20, 2025
Co-authored-by: Simon Kobler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug where attachments were not deleted from AWS due to incorrect entity path resolution. The fix adds support for both
.attachmentsand_attachmentssuffixes.Note: this is a temporary fix and I suggest to find another solution instead of hardcoding the children entities by the name,